x2goserver and nx-libs fixed

[eoli3n]

Fixes #30781 🥳

[eoli3n]

It misses the runit service.
I submitted a bug report to submit@bugs.x2go.org about forking problem for x2gocleansessions.
https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1545

[eoli3n]

@ahesford I think this is ok

[ahesford]

Turns out the x2gouser user is required, because x2godbadmin --createdb will fail if the user doesn't exist. Drop the make_dirs and add back the system_accounts changes that you dropped.

Also, I'm working on a --nofork patch that I will attempt to upstream, we can add the patch and create an x2gocleansessions script.

[ahesford]

The proposed patch is here: https://github.com/ahesford/x2goserver/compare/nofork.diff

[eoli3n]

• x2gouser readded
• patch nofork
• sv script

[ahesford]

I'd like to get some feedback from upstream about the x2gocleansessions patch. I submitted a pull request on their mailing list last night and it's awaiting moderation. If they stall or reject that patch, we shouldn't maintain divergent behavior here. In that case, we need to decide whether x2gocleansessions --debug >/dev/null to ignore the log spam every two seconds, let it flood logs, or make it a configurable switch for the user.

In the meantime, I force-pushed to your branch to make a few changes:

1. Add conf_files directives to nx-libs and x2goserver so users can customize files in /etc without having updates overwrite them.
2. Add a log script for the x2goserver service.
3. Drop the x2gouser_shell, because the default is nologin already.
4. Remove the /etc/logcheck directory from x2goserver, because we don't provide logcheck.
5. Revbump x2goclient to update metadata in the built package.

[eoli3n]

Does x2gocleansessions output anything without --debug ? If no, x2gocleansessions --debug >/dev/null is not so bad.

[ahesford]

Still nothing from upstream about --nofork. Given that the patch is minimal and the work has already been done, I'm inclined to keep it rather than try to abuse --debug.

@eoli3n are you still satisfied with the functionality of this PR?

[eoli3n]

I will take some time to retest in the week and I will ping you.
I had some random connection failures, I need to be sure that everything's ok.

[eoli3n]

On wayland, I get this after a connection with the client

Disabling wayland fix this.

QT_QPA_PLATFORM=xcb x2goclient

Arch wiki : x2goclient
Should we patch x2goclient desktop file to force xcb to increase compatibility ?

Sometimes, connection is ok, everything seems working, but the xterm window doesn't pop up.
I noticed that if the name of the session contains _dp32 it fails, but with _dp24, it succeed.

[ahesford]

I'm not inclined to modify the desktop file. That's an issue that can be fixed upstream and doesn't really prevent people from launching the client properly. Are you satisfied with the status of everything else?

[eoli3n]

Yes I do, non pop up windows should be not related to the build.