Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/build-style: add dune (OCaml builder) #31601

Closed
wants to merge 3 commits into from
Closed

Conversation

kwshi
Copy link
Contributor

@kwshi kwshi commented Jun 22, 2021

This PR defines a dune.sh build style to streamline OCaml builds using the Dune builder. Its purpose is analogous to the cargo build style for Rust projects, or python3-module build style for Python setup.py projects, etc.

As an example showing how it works, I've also added ocaml-sexplib0 (a common sexp library for OCaml), which builds using build_style=dune.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@kwshi kwshi marked this pull request as draft June 22, 2021 00:34
@kwshi kwshi force-pushed the dune branch 8 times, most recently from 222fc3d to 7d69b64 Compare June 22, 2021 02:45
@kwshi kwshi changed the title New package: dune-2.8.5 (OCaml build system), dune build-style New package: dune-2.8.5 (OCaml builder), dune build-style Jun 22, 2021
@kwshi kwshi marked this pull request as ready for review June 22, 2021 03:03
@ericonr ericonr added the new-package This PR adds a new package label Jun 23, 2021
@kwshi kwshi changed the title New package: dune-2.8.5 (OCaml builder), dune build-style common/build-style: add dune (OCaml builder) Dec 30, 2021
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 23, 2022
@github-actions github-actions bot closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants