Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: xfce4-datetime-plugin-0.8.1 #31684

Closed
wants to merge 0 commits into from
Closed

New package: xfce4-datetime-plugin-0.8.1 #31684

wants to merge 0 commits into from

Conversation

nero-0
Copy link

@nero-0 nero-0 commented Jun 27, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@ericonr ericonr added the new-package This PR adds a new package label Jun 28, 2021
configure_args="--with-locales-dir=/usr/share/locale"
hostmakedepends="pkg-config intltool"
makedepends="xfce4-panel-devel"
depends="xfce4-panel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It picks up a bunch of automatic dependencies:

   SONAME: libxfce4panel-2.0.so.4 <-> libxfce4panel>=4.12.0_1
   SONAME: libxfce4ui-2.so.0 <-> libxfce4ui>=4.12.1_2
   SONAME: libgtk-3.so.0 <-> gtk+3>=3.0.0_1
   SONAME: libgdk-3.so.0 <-> gtk+3>=3.0.0_1
   SONAME: libpango-1.0.so.0 <-> pango>=1.24.0_1
   SONAME: libgobject-2.0.so.0 <-> glib>=2.68.0_1
   SONAME: libxfce4util.so.7 <-> libxfce4util>=4.12.1_1
   SONAME: libglib-2.0.so.0 <-> glib>=2.68.0_1
   SONAME: libc.so <-> musl>=1.1.24_7

does it actually need xfce4-panel explicitly as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it requires libxfce4panel to build.
I think we can remove it from depends, but it's a plugin for the xfce4-panel so I'm not sure if there's a way to use without it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having plugins depend on the application they are a plugin for leads to weird dependency chains; I'd rather avoid that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it from depends.

@nero-0 nero-0 closed this Oct 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants