Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: git-interactive-rebase-tool #32013

Closed
wants to merge 1 commit into from
Closed

New package: git-interactive-rebase-tool #32013

wants to merge 1 commit into from

Conversation

jgarte
Copy link
Contributor

@jgarte jgarte commented Jul 17, 2021

General

Have the results of the proposed changes been tested?

  • [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

Does it build and run successfully?

  • [x ] I built this PR locally for my native architecture, (i686)

pkgname=git-interactive-rebase-tool
version=2.1.0
revision=1
archs="i686 x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a reason to do this, but if there is, it should be clearly documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericonr Hi, thanks for the feedback!

What are you referring to exactly in that snippet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericonr Are you referring to the archs variable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor Author

@jgarte jgarte Jul 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the clarification. I'll push again just to update the patch. I still have to figure out the best way to disable those failing tests.

@jgarte
Copy link
Contributor Author

jgarte commented Jul 17, 2021

Hi!

external editor tests are failing.

The nix package disables them.

What is the practice for disabling tests with xbps?

Should I take a patch or is there some other way?

Any help is much appreciated.

revision=1
archs="i686 x86_64"
build_style=cargo
short_desc="Terminal based sequence editor for git interactive rebase"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really doubt the usefulness of this tool. It's a TUI tool, in which way it improves vim/emacs?
(Let's discount the cargo cult of rustify all the things).

Copy link
Contributor Author

@jgarte jgarte Jul 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite useful. You should try it :)

git-interactive-rebase-tool paired with tig makes for a powerful alternative to features offered by magit, for example.

I primarily use vis as my preferred editor and having powerful external tools like these help with the convenience that similar tools in the emacs ecosystem or vim plugin ecosystem provide.

vis is an editor that subscribes to a unix as ide philosophy and tries to primarily leverage external tools instead of trying to write those as plugins in the editor's extension language.

@ericonr ericonr added the new-package This PR adds a new package label Jul 17, 2021
@jgarte jgarte closed this Nov 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants