Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libserialport: add patch to prevent it from using termiox, which has been removed from recent kernels #32025

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

PoroCYon
Copy link
Contributor

@PoroCYon PoroCYon commented Jul 17, 2021

Without this patch, libserialport will fail opening a tty device with an "No such ioctl for device"-error. This prevents eg. sigrok/pulseview from working with a SUMP-compatible logic analyzer.

EDIT: some clarification: see here, something like their patches would work better, but, honestly, libserialport should have a new release, 0.1.1 is from years ago.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@PoroCYon PoroCYon force-pushed the patch-libsigrok-notermiox branch 2 times, most recently from 87be829 to fe265ba Compare July 17, 2021 20:20
@PoroCYon
Copy link
Contributor Author

Hm, some builders seem to fail due to outdated local repos? Others do seem to work, though...

@PoroCYon PoroCYon changed the title add patch to prevent libserialport from using termiox, which has been removed from recent kernels libserialport: add patch to prevent it from using termiox, which has been removed from recent kernels Jul 17, 2021
@ericonr
Copy link
Member

ericonr commented Jul 17, 2021

That upstream commit should be linked in the patch.

@lemmi

@lemmi
Copy link
Member

lemmi commented Jul 17, 2021

@PoroCYon did you upstream's patch by any chance? Because you could just run git format-patch -1 6f9b03e and use that patch. That would include all attribution and the explanation of the patch.

@PoroCYon
Copy link
Contributor Author

PoroCYon commented Jul 17, 2021

I tested it, but it adds hostmakedepends on autoconf automake etc., idk if that's wanted here?

EDIT: and now I'm getting the same error as some of the builders:

=> ERROR: libserialport-0.1.1_3: failed to install 'autoconf-2.69_9' dependency! (error 16)
ERROR: [trans] failed to download `less-590_1' signature from `https://alpha.de.repo.voidlinux.org/current': Not Found
Transaction failed! see above for errors.
1 package will be downloaded:

8 packages will be installed:

  m4-1.4.18_2 
  libpcre-8.44_1 
  less-590_1 
  gdbm-1.19_1 
  libdb-5.3.28_8 
  perl-5.32.1_2 
  autoconf-2.69_9 
  automake-1.16.2_2 

Size to download:              122KB
Size required on disk:          77MB
Space available on disk:       114GB


[*] Downloading packages

so I can't really test things anymore...

@lemmi
Copy link
Member

lemmi commented Jul 17, 2021

Ah, that makes sense. I think we can add this, but as @ericonr said, please drop a short comment about upstreams patch.

termios has been removed from recent kernels, so not having this patch
causes "no such ioctl for device"-errors, preventing any use of the
library
@PoroCYon
Copy link
Contributor Author

Something like this? Seems to work (./xbps-src -I still works), but I can't test a patch that needs autoconf & automake right now.

@lemmi
Copy link
Member

lemmi commented Jul 17, 2021

Looks fine, I'll run the CI again tomorrow when the repository issues are solved.

@lemmi lemmi merged commit 54b0ac4 into void-linux:master Jul 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants