Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: xcolor-0.5.1 #33616

Closed
wants to merge 1 commit into from
Closed

Conversation

Barbaross93
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@Barbaross93 Barbaross93 changed the title Add new xcolor 0.5.1 package New Package: xcolor 0.5.1 Oct 18, 2021
@Barbaross93 Barbaross93 changed the title New Package: xcolor 0.5.1 New package: xcolor-0.5.1 Oct 18, 2021
@paper42 paper42 added the new-package This PR adds a new package label Oct 18, 2021
@Barbaross93
Copy link
Contributor Author

Sorry, this is my first time contributing. Do I need to ensure that all of the github checks pass?

@abenson
Copy link
Contributor

abenson commented Oct 29, 2021

Yes, it needs to build for all listed architectures. Also make sure the commit message follows the convention. "New package: xcolor-0.5.1`

srcpkgs/xcolor/template Outdated Show resolved Hide resolved
@biopsin
Copy link
Contributor

biopsin commented Nov 2, 2021

closes #33862

@Barbaross93
Copy link
Contributor Author

I think it's all set now. I borked the commit message a little bit, but it shouldn't be a big deal.

@Barbaross93
Copy link
Contributor Author

This PR is definitely ready now.

@apprehensions
Copy link
Contributor

thank you @Barbarossa93.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 9, 2022
@github-actions github-actions bot closed this Jun 23, 2022
@classabbyamp
Copy link
Member

merged in 64352aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants