Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carla: update to 2.4.1 (with fix to non-explicit cast with Python3.10) #33809

Merged
merged 2 commits into from Dec 7, 2021

Conversation

Animeshz
Copy link
Contributor

@Animeshz Animeshz commented Oct 29, 2021

Older version breaks on Python 3.10, see: falkTX/Carla#1489. PR simply bumps the version.

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@Animeshz
Copy link
Contributor Author

Seems like Carla itself does not support musl-libc.

@paper42
Copy link
Member

paper42 commented Oct 29, 2021

see #23390

Seems like Carla itself does not support musl-libc.

If you want to dig into it, create a patch for musl, add it to our package and submit it upstream, that would be nice. If you don't, we should fix this package anyway, so let's only patch our current version: https://github.com/falkTX/Carla/commit/3316618aa57346be5b0ab8667deab0dba7ba8c68.patch.

@Animeshz
Copy link
Contributor Author

Ok, might try tomorrow!

@ericonr
Copy link
Member

ericonr commented Oct 29, 2021

whyyy

__linux__ should work better than __gnu_linux__ there, I didn't even know about __gnu_linux__.

https://github.com/falkTX/Carla/blob/25c61989de0cfe55e4ff62af002403c9acaa1bd6/source/modules/juce_core/system/juce_SystemStats.cpp#L141 change this to #if 1, we don't want built-in backtrace reporting.

https://github.com/falkTX/Carla/blob/25c61989de0cfe55e4ff62af002403c9acaa1bd6/source/modules/juce_core/juce_core.cpp#L95 remove this line entirely.

And please ask upstream to replace their hardcoded platform knowledge with a simple configure check.

@Animeshz
Copy link
Contributor Author

Done! Builds in x86_64-musl, haven't tried others (I have data caps).

@ericonr
Copy link
Member

ericonr commented Oct 30, 2021

(please remember to squash commits)

@Animeshz Animeshz force-pushed the carla-update branch 2 times, most recently from 84c997d to 76c2b55 Compare October 31, 2021 02:47
@Animeshz
Copy link
Contributor Author

Rebased over the latest tip 👍

@ericonr
Copy link
Member

ericonr commented Nov 13, 2021

image

It seems to be stuck continuously loading DSP and pressing the New button doesn't do anything.

Also, per #23390, this is missing the liblo dependency.

@Animeshz Animeshz force-pushed the carla-update branch 2 times, most recently from cc2b646 to 097a173 Compare November 13, 2021 06:24
@ericonr
Copy link
Member

ericonr commented Nov 13, 2021

It seems to be stuck continuously loading DSP and pressing the New button doesn't do anything.

Does this happen for you? Any tips on what to investigate? I don't know if it's because I'm on musl...

@oreo639
Copy link
Member

oreo639 commented Dec 6, 2021

It seems to be stuck continuously loading DSP and pressing the New button doesn't do anything.

Does this happen for you? Any tips on what to investigate? I don't know if it's because I'm on musl...

Sorry if I am missing something but DSP load is not for "loading DSP", but is just an indicator of how much time the last frame took over the maximum amount of time available based on the sample rate and buffer size:
https://github.com/falkTX/Carla/blob/94139f07b176a5e12c7dab2e19251401c4a1461f/source/backend/engine/CarlaEngineInternal.cpp#L717-L739
As for the "new" button. That just resets the rack. If there are no plugins/VSTs loaded, then it will do nothing:
https://github.com/falkTX/Carla/blob/25c61989de0cfe55e4ff62af002403c9acaa1bd6/source/frontend/carla_host.py#L858-L867

@ericonr
Copy link
Member

ericonr commented Dec 6, 2021

This is why I was asking :)

Good to know it isn't broken, I will try to merge this soon.

jkoderu-git and others added 2 commits December 7, 2021 00:13
Needed for Carla's carla-control program.
musl patch: we disable backtrace functionality unconditionally.

Add pyliblo to depends to fix the carla-control program.
@ericonr ericonr mentioned this pull request Dec 7, 2021
@ericonr ericonr merged commit 032a0f8 into void-linux:master Dec 7, 2021
@Animeshz Animeshz deleted the carla-update branch February 13, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants