New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carla: update to 2.4.1 (with fix to non-explicit cast with Python3.10) #33809
Conversation
Seems like Carla itself does not support musl-libc. |
see #23390
If you want to dig into it, create a patch for musl, add it to our package and submit it upstream, that would be nice. If you don't, we should fix this package anyway, so let's only patch our current version: https://github.com/falkTX/Carla/commit/3316618aa57346be5b0ab8667deab0dba7ba8c68.patch. |
Ok, might try tomorrow! |
https://github.com/falkTX/Carla/blob/25c61989de0cfe55e4ff62af002403c9acaa1bd6/source/modules/juce_core/system/juce_SystemStats.cpp#L141 change this to https://github.com/falkTX/Carla/blob/25c61989de0cfe55e4ff62af002403c9acaa1bd6/source/modules/juce_core/juce_core.cpp#L95 remove this line entirely. And please ask upstream to replace their hardcoded platform knowledge with a simple configure check. |
Done! Builds in x86_64-musl, haven't tried others (I have data caps). |
(please remember to squash commits) |
84c997d
to
76c2b55
Compare
Rebased over the latest tip 👍 |
It seems to be stuck continuously loading DSP and pressing the Also, per #23390, this is missing the liblo dependency. |
cc2b646
to
097a173
Compare
Does this happen for you? Any tips on what to investigate? I don't know if it's because I'm on musl... |
Sorry if I am missing something but |
This is why I was asking :) Good to know it isn't broken, I will try to merge this soon. |
Needed for Carla's carla-control program.
musl patch: we disable backtrace functionality unconditionally. Add pyliblo to depends to fix the carla-control program.
Older version breaks on Python 3.10, see: falkTX/Carla#1489. PR simply bumps the version.
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)