Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: update to 0.20.1. #34297

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

jgarte
Copy link
Contributor

@jgarte jgarte commented Nov 29, 2021

Testing the changes

  • I tested the changes in this PR: NO

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@jgarte
Copy link
Contributor Author

jgarte commented Nov 29, 2021

@ericonr

linter complains:

revision should be set to 1 on update

But I set the revision to 2.

How come?

xlint didn't complain before I pushed the pr here.

@ericonr
Copy link
Member

ericonr commented Nov 29, 2021

It's the same thing as explained in #34180 (comment)

We only need revisions when the version remains the same. Once the version changes, we reset the revision.

@cinerea0
Copy link
Contributor

I'm currently testing this version of tree-sitter with neovim, seems to work perfectly.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 29, 2021

It's the same thing as explained in #34180 (comment)

We only need revisions when the version remains the same. Once the version changes, we reset the revision.

@ericonr
Got it! I pushed that change.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 29, 2021

I'm currently testing this version of tree-sitter with neovim, seems to work perfectly.

How are you testing tree-sitter?

Could you share a tip? :)

@cinerea0
Copy link
Contributor

How are you testing tree-sitter?

I use tree-sitter indirectly because I use neovim with a few plugins that rely on its functionality. If tree-sitter broke, tons of things about my editor would be broken. Unfortunately I don't have a great way to test it directly. Sorry :(

@ericonr ericonr merged commit 9664776 into void-linux:master Dec 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants