Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: update to 1.50.2 #34422

Merged
merged 1 commit into from
Dec 21, 2021
Merged

pango: update to 1.50.2 #34422

merged 1 commit into from
Dec 21, 2021

Conversation

cinerea0
Copy link
Contributor

@cinerea0 cinerea0 commented Dec 7, 2021

Testing the changes

  • I tested the changes in this PR: YES

@ericonr
Copy link
Member

ericonr commented Dec 8, 2021

I've found the musl test failure. Our glib is misconfigured due to a lack of CFLAGS (upstream's fault, I'm not sure how it went undetected before).

It should be using the USE_XLOCALE code path in gstrfuncs.c, but it isn't, so it's using the g_ascii_formatd implementation, which has a mistaken g_return_val_if_fail (format[0] == '%', NULL); for some reason. It fails, because the format being passed is " %f" (note the space).

I'm not sure why the test exists, but trying to fix glib first.

@ericonr
Copy link
Member

ericonr commented Dec 8, 2021

My mistake, glib isn't misconfigured, musl doesn't have strtoll_l or strtoull_l.

So possibly patching out the assert is enough, will check.

@ericonr
Copy link
Member

ericonr commented Dec 8, 2021

the code is 20y old, I'm curious how it was never caught before :P

@ericonr
Copy link
Member

ericonr commented Dec 8, 2021

Am trying again.

srcpkgs/pango/template Outdated Show resolved Hide resolved
@cinerea0 cinerea0 changed the title pango: update to 1.50.0 pango: update to 1.50.1 Dec 12, 2021
@cinerea0 cinerea0 changed the title pango: update to 1.50.1 pango: update to 1.50.2 Dec 16, 2021
@cinerea0 cinerea0 marked this pull request as draft December 16, 2021 21:48
@cinerea0
Copy link
Contributor Author

Temporarily marking as draft so I can test 1.50.2 fully.

@cinerea0
Copy link
Contributor Author

@ericonr The checks are failing again.

@ericonr
Copy link
Member

ericonr commented Dec 17, 2021

Oof, these are different failures...

@ericonr
Copy link
Member

ericonr commented Dec 21, 2021

So uh, tests work here :p

@ericonr ericonr marked this pull request as ready for review December 21, 2021 03:27
@ericonr ericonr merged commit 77a8a0c into void-linux:master Dec 21, 2021
@cinerea0 cinerea0 deleted the pango branch December 21, 2021 16:53
@ram02z
Copy link
Contributor

ram02z commented Dec 30, 2021

This pango update broke text rendering on swaybar.

@ericonr
Copy link
Member

ericonr commented Dec 30, 2021

@ram02z can you please open an issue and share screenshots?

I don't think this has been reported to sway upstream yet :/

@cinerea0
Copy link
Contributor Author

@ram02z Also, could you check if the update in #34725 fixes your problem?

@ram02z
Copy link
Contributor

ram02z commented Dec 30, 2021

@ram02z can you please open an issue and share screenshots?

I don't think this has been reported to sway upstream yet :/

Sorry, it was i3status-rs, not swaybar.
Seems to be this greshake/i3status-rust#1367

@ram02z Also, could you check if the update in #34725 fixes your problem?

Yeah, pango 1.50.3 fixes the bug.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants