New package: onionshare-{cli, dekstop}-2.4 #34599
Conversation
There was a problem hiding this comment.
I previously removed an older version of this package (#32416) because it didn't work, updating to a newer version was complicated and in the end required Flask1 which we don't have. Did something change?
Also, please rebase on top of master, so the CI can run.
srcpkgs/onionshare-cli/template
Outdated
| do_build() { | ||
| cd cli | ||
| python3 setup.py build ${make_build_args} | ||
| } | ||
|
|
||
| do_install() { | ||
| cd cli | ||
| python3 setup.py install --prefix=/usr --root=${DESTDIR} ${make_install_args} | ||
| } |
There was a problem hiding this comment.
| do_build() { | |
| cd cli | |
| python3 setup.py build ${make_build_args} | |
| } | |
| do_install() { | |
| cd cli | |
| python3 setup.py install --prefix=/usr --root=${DESTDIR} ${make_install_args} | |
| } | |
| build_wrksrc=cli |
|
Hi, i know that onionshare was remove before, for reasons of not working, but since then several version came by, and merge onionshare/onionshare#1399 fixes issue of having Flask2 installed on your system from package manager. The package now works, with no issues (that i found at least) |
DragonGhost7
force-pushed
the
onionshare
branch
2 times, most recently
from
49ca91d
to
82fe12b
Compare
srcpkgs/python3-bidict/template
Outdated
| maintainer="DragonGhost7 <darkiridiumghost@gmail.com>" | ||
| license="MPL-2.0" | ||
| homepage="https://github.com/jab/bidict" | ||
| distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz" |
There was a problem hiding this comment.
please don't use $homepage in $distfiles
| license="GPL-3.0-or-later" | ||
| homepage="https://onionshare.org/" | ||
| changelog="https://raw.githubusercontent.com/micahflee/onionshare/develop/CHANGELOG.md" | ||
| distfiles="https://github.com/micahflee/onionshare/archive/v${version}.tar.gz" |
There was a problem hiding this comment.
onionshare-cli and onionshare-desktop have the same distfiles, so they should either be built in the same template or have a comment on top to remind people updating this package to keep the versions synchronized between both templates.
There was a problem hiding this comment.
yeah i think best would be to make onionshare-desktop a subpackage of onionshare, managinf the 2 will be much easier
There was a problem hiding this comment.
but they have separate builds, and installs, so might be complicated
srcpkgs/python3-engineio/template
Outdated
| wrksrc="python-engineio-${version}" | ||
| build_style=python3-module | ||
| hostmakedepends="python3-setuptools python3-Sphinx" | ||
| makedepends="${depends}" |
There was a problem hiding this comment.
$depends is not defined here and you probably don't want the dependencies in makedepends
| changelog="https://raw.githubusercontent.com/micahflee/onionshare/develop/CHANGELOG.md" | ||
| distfiles="https://github.com/micahflee/onionshare/archive/v${version}.tar.gz" | ||
| checksum=9d82744ec930a280cf036e5e7dfab817a37866e927e5a72bdd3e13bd9b9c7b4a | ||
|
|
There was a problem hiding this comment.
remove this blank line and fix the xlint warning
DragonGhost7
force-pushed
the
onionshare
branch
from
82fe12b
to
66fb397
Compare
DragonGhost7
force-pushed
the
onionshare
branch
from
66fb397
to
c655b57
Compare
DragonGhost7
force-pushed
the
onionshare
branch
from
c655b57
to
b8bcb38
Compare
|
Ok so, in the end dividing them into sub packages is really not trivial, nor useful, because onionshare-cli and onionshare-desktop have different tests, and installing onionshare-desktop becomes really hard. What is the problem with x86_64-musl, i am not sure, but the i686 and x86_64 fail for an absolutely unknown reason, i will have to try to replicate that more. on my machine it works, even from a tty. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing