Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsxiv: update to 29 #35944

Merged
merged 1 commit into from
Mar 20, 2022
Merged

nsxiv: update to 29 #35944

merged 1 commit into from
Mar 20, 2022

Conversation

WitherCubes
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@tibequadorian
Copy link
Contributor

Build error is probably not architecture related, but fails due to cross compiling. Specify nocross=yes instead of restricting archs. But preferably you should figure out how to fix cross builds.

@WitherCubes
Copy link
Contributor Author

I will change it to nocross=yes for the moment, I will look into fixing cross builds after discussing with the nsxiv dev team.

@paper42
Copy link
Member

paper42 commented Mar 3, 2022

Do not add nocross=yes and remove the architecture restriction, so we can see what's happening.

@tibequadorian
Copy link
Contributor

This could be relevant: https://github.com/nsxiv/nsxiv/issues/237

@N-R-K
Copy link

N-R-K commented Mar 3, 2022

This could be relevant: nsxiv/nsxiv#237

Seems to be the case from the logs, it compiled fine but then failed when trying to install.

@paper42
Copy link
Member

paper42 commented Mar 3, 2022

Seems to be the case from the logs, it compiled fine but then failed when trying to install.

For some reason it tries to create options.o and fails before do_install doesn't set cross flags.

@tibequadorian
Copy link
Contributor

With your patch from nsxiv/nsxiv#238 it does work @N-R-K

@N-R-K
Copy link

N-R-K commented Mar 3, 2022

Just removing all from the install prerequisite should work as well. This is what I do on the gentoo::guru package: sed -i -e '/^install: / s|: all|:|' Makefile.

@paper42 paper42 mentioned this pull request Mar 5, 2022
@paper42
Copy link
Member

paper42 commented Mar 13, 2022

Give the patch an appropriate name and a description, this doesn't tell us anything.

@WitherCubes
Copy link
Contributor Author

WitherCubes commented Mar 14, 2022

Give the patch an appropriate name and a description, this doesn't tell us anything.

I can't come up with a proper name and description, could you please recommend something?

BTW the issue that is fixed by the patch is this.

@N-R-K
Copy link

N-R-K commented Mar 15, 2022

Description: "Don't rebuild options.o when installing" (?)
Name: idk, "Fix install" maybe.

@WitherCubes
Copy link
Contributor Author

I have added the proper patch name and description.

@paper42 paper42 merged commit 9089f55 into void-linux:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants