-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-firmware: move MediaTek firmware #36120
Conversation
Should also move
|
ef836dd
to
0249539
Compare
... that doesnt make sense. you need to move the symlinks, the targets are already there. |
srcpkgs/linux-firmware/template
Outdated
vmove usr/lib/firmware/mediatek/mt8173/vpu_d.bin | ||
vmove usr/lib/firmware/mediatek/mt8173/vpu_p.bin | ||
vmove usr/lib/firmware/mediatek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sketchy
Apologies, I had misread what you meant, but I'm still somewhat confused as to what is needed to be done. I'm somewhat new with this. |
Please fix this PR, it should only contain one commit. If you have questions about this, we can help you on IRC. |
ca0a7bb
to
451df31
Compare
Alright this should be fixed now. Apologies for the mess. |
9a12353
to
00af8fb
Compare
Is there anything blocking this? It'd be nice to get this merged. |
I believe @leahneukirchen's comment from March still applies, |
fwiw i don't think a bunch of the mediatek firmware should go to -network (notably the vpu_* stuff as that's not network-related at all) there is also a lot of firmware in the main package that should go to -network though |
From a cursory glance, it looks like all the files in in the mediatek folder are network related, but the directories aren't. |
Here's how Chimera Linux does it currently, maybe we could do something similar? would allow us to separate the network-related and ARM SoC specific files by moving the ladder to a Also this commit currently is very vague: @Sapein are you interested in continuing (to fix) this PR? |
Hey, sorry for the disappearance, but yes I am still interested in continuing this PR and attempting to fix it. Part of the issue is that I am a bit unfamiliar with Packaging in general (and Void Linux packaging in particular), so I'm unsure how to go about fixing it. I can adjust the commit message to be something like: |
Hey, I've been trying to do some work locally, if I should split off the firmware into two packages, would I need two separate PRs? Additionally, what would I need to do to move the vpu_d.bin and vpu_p.bin files, as I'm unsure what to do with that in particular. |
Currently only some MediaTek firmware is moved in linux-firmware-network, this moves the rest into the package.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Currently only some MediaTek firmware is moved.
Testing the changes