Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-firmware: move MediaTek firmware #36120

Closed
wants to merge 1 commit into from
Closed

Conversation

Sapein
Copy link

@Sapein Sapein commented Mar 13, 2022

Currently only some MediaTek firmware is moved.

Testing the changes

  • I tested the changes in this PR: YES

@leahneukirchen
Copy link
Member

Should also move

linux-firmware-20220209_1	/usr/lib/firmware/vpu_d.bin -> /usr/lib/firmware/mediatek/mt8173/vpu_d.bin
linux-firmware-20220209_1	/usr/lib/firmware/vpu_p.bin -> /usr/lib/firmware/mediatek/mt8173/vpu_p.bin

@Sapein Sapein force-pushed the master branch 2 times, most recently from ef836dd to 0249539 Compare March 14, 2022 21:38
@leahneukirchen
Copy link
Member

... that doesnt make sense. you need to move the symlinks, the targets are already there.

Comment on lines 98 to 100
vmove usr/lib/firmware/mediatek/mt8173/vpu_d.bin
vmove usr/lib/firmware/mediatek/mt8173/vpu_p.bin
vmove usr/lib/firmware/mediatek
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sketchy

@Sapein
Copy link
Author

Sapein commented Mar 17, 2022

... that doesnt make sense. you need to move the symlinks, the targets are already there.

Apologies, I had misread what you meant, but I'm still somewhat confused as to what is needed to be done. I'm somewhat new with this.

@paper42
Copy link
Member

paper42 commented Mar 23, 2022

Please fix this PR, it should only contain one commit. If you have questions about this, we can help you on IRC.

@Sapein Sapein force-pushed the master branch 3 times, most recently from ca0a7bb to 451df31 Compare March 23, 2022 14:59
@Sapein
Copy link
Author

Sapein commented Mar 23, 2022

Please fix this PR, it should only contain one commit. If you have questions about this, we can help you on IRC.

Alright this should be fixed now. Apologies for the mess.

@nicegamer7
Copy link

Is there anything blocking this? It'd be nice to get this merged.

@JamiKettunen
Copy link
Contributor

JamiKettunen commented Oct 19, 2022

I believe @leahneukirchen's comment from March still applies, /usr/lib/firmware/vpu_{d,p}.bin are still not being moved to the -network subpackage as well.

@q66
Copy link
Contributor

q66 commented Oct 20, 2022

fwiw i don't think a bunch of the mediatek firmware should go to -network (notably the vpu_* stuff as that's not network-related at all)

there is also a lot of firmware in the main package that should go to -network though

@nicegamer7
Copy link

From a cursory glance, it looks like all the files in in the mediatek folder are network related, but the directories aren't.

@JamiKettunen
Copy link
Contributor

Here's how Chimera Linux does it currently, maybe we could do something similar? would allow us to separate the network-related and ARM SoC specific files by moving the ladder to a linux-firmware-mediatek subpackage and then bringing rest of mediatek dir and mt7*.bin into linux-firmware-network.

Also this commit currently is very vague: linux-firmware: move MediaTek firmware, move them where? obviously into -network subpackage but it could be more specific for commit history readability

@Sapein are you interested in continuing (to fix) this PR?

@Sapein
Copy link
Author

Sapein commented Nov 23, 2022

Here's how Chimera Linux does it currently, maybe we could do something similar? would allow us to separate the network-related and ARM SoC specific files by moving the ladder to a linux-firmware-mediatek subpackage and then bringing rest of mediatek dir and mt7*.bin into linux-firmware-network.

Also this commit currently is very vague: linux-firmware: move MediaTek firmware, move them where? obviously into -network subpackage but it could be more specific for commit history readability

@Sapein are you interested in continuing (to fix) this PR?

Hey, sorry for the disappearance, but yes I am still interested in continuing this PR and attempting to fix it. Part of the issue is that I am a bit unfamiliar with Packaging in general (and Void Linux packaging in particular), so I'm unsure how to go about fixing it. I can adjust the commit message to be something like: move MediaTek firmware into linux-firmware-network if desired, although I'm not sure how to best adjust the commit message.

@Sapein
Copy link
Author

Sapein commented Dec 2, 2022

Here's how Chimera Linux does it currently, maybe we could do something similar? would allow us to separate the network-related and ARM SoC specific files by moving the ladder to a linux-firmware-mediatek subpackage and then bringing rest of mediatek dir and mt7*.bin into linux-firmware-network.

Also this commit currently is very vague: linux-firmware: move MediaTek firmware, move them where? obviously into -network subpackage but it could be more specific for commit history readability

@Sapein are you interested in continuing (to fix) this PR?

Hey, I've been trying to do some work locally, if I should split off the firmware into two packages, would I need two separate PRs? Additionally, what would I need to do to move the vpu_d.bin and vpu_p.bin files, as I'm unsure what to do with that in particular.

Currently only some MediaTek firmware is moved in
linux-firmware-network, this moves the rest into the package.
@paper42 paper42 added the core core package label Dec 23, 2022
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 24, 2023
@github-actions github-actions bot closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core core package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants