Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: giph-1.1.1 #36363

Closed
wants to merge 1 commit into from
Closed

New package: giph-1.1.1 #36363

wants to merge 1 commit into from

Conversation

notchtc
Copy link

@notchtc notchtc commented Mar 26, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • armv7l

@subnut
Copy link
Contributor

subnut commented Mar 26, 2022

This package does NOT meet the quality requirements -

  1. 🚫 System: It's a single shell script, and can be run just as well from the ~/.local/bin directory.
  2. 🚫 Compiled: It isn't. It's a simple shell script.
  3. 🚫 Required: No other package requires it.

@paper42 paper42 closed this Mar 26, 2022
@paper42
Copy link
Member

paper42 commented Mar 26, 2022

This package doesn't meet quality requirements.

@paper42 paper42 added the new-package This PR adds a new package label Mar 26, 2022
maintainer="chtc <notnotcha0t1c@protonmail.com>"
license="MIT"
homepage="https://github.com/phisch/giph"
distfiles="${homepage}/archive/refs/tags/${version}.tar.gz>${pkgname}-${version}.tar.gz"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used to specify the filename. In this scenario it's actually useless because the filename isn't different but I was copy and pasting from another template I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants