Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongoose: update to 7.6 #36395

Closed
wants to merge 1 commit into from
Closed

mongoose: update to 7.6 #36395

wants to merge 1 commit into from

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Mar 28, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@subnut

This comment was marked as resolved.

@subnut

This comment was marked as resolved.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That automatic dependency resolution fails to find the mbedtls dependency isn't surprising. You should be adding the appropriate SSL -devel package as a dependency of mongoose-devel to make sure it pulls in what would be needed for linking.

srcpkgs/mongoose/template Outdated Show resolved Hide resolved
srcpkgs/mongoose/template Show resolved Hide resolved
srcpkgs/mongoose/template Outdated Show resolved Hide resolved
srcpkgs/mongoose/template Outdated Show resolved Hide resolved
@Johnnynator
Copy link
Member

A patch like the following should stop make attempting to recompile everything in do_install.

@@ -108,9 +108,12 @@
 linux++: WARN += -Wno-missing-field-initializers
 linux++: linux
 
-linux-libs: CFLAGS += -fPIC
-linux-libs: mongoose.o
+CFLAGS += -fPIC
+.PHONY: linux-libs
+linux-libs: libmongoose.a libmongoose.so.$(VERSION)
+libmongoose.so.$(VERSION): mongoose.o
        $(CC) mongoose.o $(LDFLAGS) -shared -o libmongoose.so.$(VERSION)
+libmongoose.a: mongoose.o
        $(AR) rcs libmongoose.a mongoose.o
 
 install: linux-libs

@subnut subnut force-pushed the mongoose branch 7 times, most recently from 4c5dad0 to f2df061 Compare March 29, 2022 06:05
@subnut

This comment was marked as outdated.

@subnut subnut requested a review from ahesford March 29, 2022 06:12
@subnut subnut marked this pull request as ready for review March 29, 2022 06:15
@subnut
Copy link
Contributor Author

subnut commented Mar 29, 2022

GitHub's CI runners don't support ipv6 at all.
Not even local loopback.

That's why the tests are failing.
It's failing while trying to listen on [::1]:12346, which is ipv6.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would seem that, in the unit test file, you can just replace the #if MG_ENABLE_IPV6 that guards the IPv6 listener with #if 0 to prevent the IPv6 problem.

srcpkgs/mongoose/patches/fix-tests.patch Show resolved Hide resolved
srcpkgs/mongoose/patches/fix-makefile.patch Outdated Show resolved Hide resolved
@subnut subnut force-pushed the mongoose branch 4 times, most recently from f764b78 to 22a5edb Compare March 29, 2022 12:47
@subnut subnut requested a review from ahesford March 29, 2022 12:52
srcpkgs/mongoose/template Outdated Show resolved Hide resolved
@subnut subnut force-pushed the mongoose branch 3 times, most recently from b787279 to e74bf49 Compare March 30, 2022 15:19
@subnut subnut marked this pull request as draft March 30, 2022 15:35
@subnut subnut force-pushed the mongoose branch 4 times, most recently from 540290c to cddea5b Compare March 30, 2022 15:57
@subnut subnut marked this pull request as ready for review March 30, 2022 15:59
@subnut subnut requested a review from ahesford March 30, 2022 15:59
srcpkgs/mongoose/template Outdated Show resolved Hide resolved
@subnut subnut force-pushed the mongoose branch 2 times, most recently from e5d0fe0 to f2ad227 Compare March 31, 2022 11:54
@subnut subnut requested a review from ahesford March 31, 2022 12:02
@ahesford ahesford closed this in d6fe012 Mar 31, 2022
@subnut subnut deleted the mongoose branch March 31, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants