Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine rust and cargo templates #36426

Closed
wants to merge 2 commits into from

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Mar 31, 2022

@q66, wanted to get your opinion on these changes before I go further. I did my best to fold the cargo{,-bootstrap} templates into the rust{,-bootstrap} ones, preserving all patches and fixes. Tested successfully with a cross build x86_64 to aarch64. If this looks fine, I can continute working on doing some cleanups and update to 1.59 (although there is a PR for that already).

Testing the changes

  • I tested the changes in this PR: YES

[ci skip]

@q66
Copy link
Contributor

q66 commented Mar 31, 2022

i don't see how this is supposed to cross compile, considering it does not really fix anything and rustbuild for cross stage 2 tools is not ready

@classabbyamp
Copy link
Member Author

If stage 2 tools can't be crossed, then how was I able to successfully cross-build and use cargo using these templates?

@q66
Copy link
Contributor

q66 commented Mar 31, 2022

luck with a particular target combo? the tools get built with the right compiler, but they get the host's flags and environment (in rust build, they get build+host == the build env and target == the target env, while all correctly cross-compiled stuff should be build == build env and host+target == target env, but the logic for tools is hardcoded in the rustbuild code and when I looked into it it seemed extremely non-trivial to fix), which results in weirdness (in my cases, actual build failures; i tested this when doing the 1.57 update)

@classabbyamp classabbyamp deleted the rust-unified branch May 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants