New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: font-awesome6-6.1.1 #37019
Conversation
0824fa6
to
c39f682
Compare
as i understand it, each generation of font-awesome is a different set/style of icons. font-awesome 4 and 5 are already packaged separately, so it would make sense to continue that i guess. |
Isn't it supposed to conflict with the other Add this to the template - conflicts="font-awesome>=0" Refer to the template for Other than that, LGTM 👍 |
I am not sure. I did not do it, since there are no file conflicts :)
Yep, that is my template also :P
Thanks for the review! |
no, they are different fonts. why would they conflict? |
🤷 I just thought that, since font-awesome5 conflicts with font-awesome, font-awesome6 would also conflict with it. |
I have to test this. I think version 6 is not conflicting in any way (I have it in my system alongside v5). I do not remember why I added the conflit in v5 unfortunately... |
it should be fine to remove the 4/5 conflict: $ diff -u <(xls font-awesome) <(xls font-awesome5)
--- /proc/self/fd/11 2022-05-14 10:53:24.439310999 -0400
+++ /proc/self/fd/12 2022-05-14 10:53:24.440311001 -0400
@@ -1 +1,3 @@
-/usr/share/fonts/OTF/FontAwesome.otf
+/usr/share/fonts/OTF/Font Awesome 5 Brands-Regular-400.otf
+/usr/share/fonts/OTF/Font Awesome 5 Free-Regular-400.otf
+/usr/share/fonts/OTF/Font Awesome 5 Free-Solid-900.otf |
|
Testing the changes
New package
Not sure if that should be a new package or replace font-awesome5...