Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XFCE4-PLUGIN templates. #37028

Closed
wants to merge 9 commits into from
Closed

Fix XFCE4-PLUGIN templates. #37028

wants to merge 9 commits into from

Conversation

IT-DEVS-Group
Copy link

@IT-DEVS-Group IT-DEVS-Group commented May 7, 2022 •
edited
Loading

  • I tested the changes in this PR: NO

@abenson
Copy link
Contributor

abenson commented May 9, 2022

  1. One commit per template.
  2. Follow the convention for naming, i.e. XFCE_SITE
  3. The Manual.md space changes should be separate from this PR.

@Chocimier
Copy link
Member

Chocimier commented May 9, 2022 •
edited
Loading

  1. revision is not supposed to be derived from version but be independent from version, see Manual.md
  2. adjust templates to xlint rules, see CONTRIBUTING.md
  3. please, provide meaningful and complete summary of changes proposed. "Fix templates" is neither useful nor correct.

@Chocimier
Copy link
Member

There is no point in changing msttcorefonts if resulting package is same. Also create separate PRs for unrelated packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IT-DEVS-Group @abenson @Chocimier @vadzimnaumuk