Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/build-style/cargo.sh: use offline install #37029

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

0x5c
Copy link
Contributor

@0x5c 0x5c commented May 7, 2022

This prevents cargo install from wasting time fetching the crate registry.

[CI skip]

Testing the changes

  • I tested the changes in this PR: YES

@ericonr
Copy link
Member

ericonr commented May 14, 2022

Please don't add [ci skip] to the commit itself, it's enough in the PR description.

Which packages have you tested with this?

@0x5c
Copy link
Contributor Author

0x5c commented May 14, 2022

Please don't add [ci skip] to the commit itself, it's enough in the PR description.

It got there because I was writing my commit message in so it could be the PR message as-is. Didn't think it fully through tho. I can remove it if you want

Which packages have you tested with this?

I tested it with riff (#37013), but it should work for everything else since fetching the registry in the install phase doesn't have an effect in the first place because we use --locked in the install. So this gets rid of a long networked no-op that can fail (the Updating crates.io index line in the install phase).

@ericonr
Copy link
Member

ericonr commented May 16, 2022

I can remove it if you want

Please do :)

I'm going to try and test this around a bit.

@ericonr ericonr self-assigned this May 16, 2022
@0x5c
Copy link
Contributor Author

0x5c commented May 17, 2022

The commit message has been cleaned

This prevents `cargo install` from wasting time fetching the crate registry.
@ericonr ericonr merged commit 52729f3 into void-linux:master Jun 11, 2022
@0x5c 0x5c deleted the rust-install-offline branch June 11, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants