dkms: update to 3.0.6 and update other related packages #37139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnut
commented
May 15, 2022
Closed
ahesford
requested changes
May 17, 2022
subnut
force-pushed
the
dkms
branch
4 times, most recently
from
0dd65a0
to
1ae0908
Compare
ahesford
requested changes
May 18, 2022
subnut
force-pushed
the
dkms
branch
3 times, most recently
from
2b8aa65
to
0f5aa33
Compare
ahesford
reviewed
May 21, 2022
subnut
force-pushed
the
dkms
branch
2 times, most recently
from
472de9b
to
48bf6bb
Compare
subnut
changed the title
|
Sorry for the delay, I am busy. @ahesford It makes the logic simpler IMO. I've updated the logic again, and this time I've only utilized the expected format instead of using workarounds like If you have any better suggestions, do share. I'll implement it ASAP. Thanks for the |
|
Reference for |
ahesford
previously requested changes
Jun 22, 2022
srcpkgs/zfs/patches/0001-only-build-the-module-in-dkms.conf.patch
Outdated
Show resolved
Hide resolved
ahesford
reviewed
Jun 28, 2022
subnut
force-pushed
the
dkms
branch
2 times, most recently
from
1140382
to
b1b9214
Compare
subnut
changed the title
|
Updated to latest release and rebased on |
ahesford
requested changes
Jul 21, 2022
ahesford
requested changes
Jul 21, 2022
files/kernel.d/dkms.prerm has been updated to match the kernel_prerm.d_dkms file distributed with dkms 3.0.6 Also, note that these dkms.conf directives have been deprecated since dkms 2.8.8 - MODULES_CONF - MODULES_CONF_ALIAS_TYPE - MODULES_CONF_OBSOLETES - MODULES_CONF_OBSOLETE_ONLY - REMAKE_INITRD Also, note that the output of `dkms status` was changed in version 2.8.6 old - zfs, 2.1.4, 5.15.39_1, x86_64: installed new - zfs/2.1.4, 5.15.39_1, x86_64: installed
The output format of `dkms status` has changed in v2.8.6 old - zfs, 2.1.4, 5.15.39_1, x86_64: installed new - zfs/2.1.4, 5.15.39_1, x86_64: installed So, I've re-worked the _modver and _kver detection logic. NOTE: The detection logic should ideally be identical to the detection logic in srcpkgs/dkms/files/kernel.d/dkms.prerm Also, there was a bug. If a package tried to install a dkms module that failed to build for *all* of the installed kernels, then the output of dkms status for that module would be - old - module-name, x.y.z: added new - module-name/x.y.z: added Which would cause the dkms trigger to set _kver to "added", and then the following call to `dkms remove` would set the flag `-k $_kver`, and dkms would get confused trying to find a kernel of version "added". This commit fixes that bug.
|
Sorry for the |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hey @subnut, is there something I can help you with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing