New package: libguestfs-tools 1.48.0

[chexum]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the quality requirements: YES

perl-Locale-TextDomain is only introduced for the script in perl.

libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:

https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c

Without this package, important tools like virt-sysprep were not provided at all.

The package is guestfs-tools but all other distributions align the package name with libguestfs.

Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.

Part of the test suite is downloading a test VM image, which is roughly the purpose of the update-libguestfs-appliance script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.

(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)

Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)

---

Local build testing

• I built this PR locally for my native architecture, (x86_64-glibc)
• Could not test any other archs, will check the CI

[chexum]

Just to reitarate, 22 of the packages documented on https://libguestfs.org/ are no longer actually part of the shipped void libguestfs package. libguestfs-tools may be "new" but all it contains is the remaining tools that were previously part of libguestfs.

[Duncaen]

We generally use upstream names, anything wrong with using guestfs-tools?

[chexum]

We generally use upstream names, anything wrong with using guestfs-tools?

Even the internal library common to libguestfs and guestfs-tools is residing in libguestfs-common. Perhaps the vendor name was chosen to only have a name that's shorter to type, but it's all still for the libguestfs family. Both the two major distributions use the name libguestfs-tools as well. This way it could reduce the confusion of both new users, to learn about the package, and users from other distributions, to find the package they know.

[chexum]

Of course I'm not quite sure if the choice of the non-upstream package name libguestfs-tools is correct. However, when trying to find out where did virt-sysprep (for example) has gone from libguestfs, it took a nontrivial amount of time to see that it's now in a package that's not yet shipping. If void were to use the name established by the deb and rpm folks, it at least smooths the transition for people using documentation written with those distributions in mind. Perhaps surprisingly, this includes the upstream web site, so I have a fair point that this is actually the upstream name:

https://libguestfs.org/

sudo yum install libguestfs-tools      # Fedora/RHEL/CentOS
sudo apt-get install libguestfs-tools  # Debian/Ubuntu

Furthermore, it should also make it easier to find it by xbps-query -Rs libguestfs. Would any user think that they need to use xbps-query -Rs guestfs instead? If these points still don't make sense over the upstream naming rule, I'd be happy to oblige, and change the name.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[chexum]

Yes, I'd still like to have this merged - give me some time to review recent changes

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[chexum]

still working on getting back on my feet and retesting this package, appreciate the patience

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[sogaiu]

I ended up here looking for a package that might contain virt-filesystems, I guess there hasn't been too much demand for it (^^;