-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: libguestfs-tools 1.48.0 #37416
Conversation
Just to reitarate, 22 of the packages documented on https://libguestfs.org/ are no longer actually part of the shipped void libguestfs package. libguestfs-tools may be "new" but all it contains is the remaining tools that were previously part of libguestfs. |
We generally use upstream names, anything wrong with using |
Even the internal library common to |
libintl-perl 0.32, as a dependency for (lib)guestfs-tools.
Some tools were removed before libguestfs 1.45.2 and split into another package, see commit: 733d2182b64df7abc5c5cd7d78177baa6079628c in https://github.com/libguestfs/libguestfs/ Without this package, important tools like virt-sysprep were not provided at all. The package is guestfs-tools but all other distributions align the package name with libguestfs. Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Of course I'm not quite sure if the choice of the non-upstream package name
Furthermore, it should also make it easier to find it by |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Yes, I'd still like to have this merged - give me some time to review recent changes |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
still working on getting back on my feet and retesting this package, appreciate the patience |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
I ended up here looking for a package that might contain |
Testing the changes
New package
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the
update-libguestfs-appliance
script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
Local build testing