Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer: update to 2022.06.06 #37423

Closed
wants to merge 5 commits into from
Closed

rust-analyzer: update to 2022.06.06 #37423

wants to merge 5 commits into from

Conversation

jawadcode
Copy link

Testing the changes

  • I tested the changes in this PR: YES|briefly|NO
    YES

New package

@classabbyamp
Copy link
Member

classabbyamp commented Jun 6, 2022

I tested the changes in this PR: YES|briefly|NO
YES

error: package xshell-macros v0.2.1 cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.57.0

did you actually test this? it will fail to build until #37232 is merged.

@jawadcode
Copy link
Author

I tested the changes in this PR: YES|briefly|NO
YES

error: package xshell-macros v0.2.1 cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.57.0

did you actually test this? it will fail to build until #37232 is merged.

Apologies, I misunderstood the question and tested by compiling that version of rust-analyzer from source manually instead of using the xbps tools.

Sorry for wasting your time

@classabbyamp
Copy link
Member

it's fine, it can still get merged but it will have to wait on the rust update

@jawadcode
Copy link
Author

it's fine, it can still get merged but it will have to wait on the rust update

Yeah I'll just leave it open in the meanwhile

@Chocimier Chocimier marked this pull request as draft June 6, 2022 19:55
@jawadcode jawadcode marked this pull request as ready for review June 7, 2022 17:07
@tranzystorekk
Copy link
Contributor

Rust 1.61 is there, I think this PR is good to go ☺️

@jawadcode
Copy link
Author

it's fine, it can still get merged but it will have to wait on the rust update

@classabbyamp Would it be possible to merge this PR now since #37232 has been merged?

@classabbyamp
Copy link
Member

classabbyamp commented Jun 9, 2022

it should build now, yes, but there's still some work to be done with this PR before it can be merged (and I can't merge it anyways, I'm not a maintainer). The things I can see are:

  • the comment I made earlier about the distfiles url
  • one commit per package (you can use git squash and git push --force) to fix this, (and in the future merge from master by using git pull --rebase upstream master to avoid the merge commit)
  • testing what xbps-src builds (I can help with this, I use this package)

jawadcode and others added 3 commits June 9, 2022 01:40
rust-analyzer is part of the rust-lang organisation now

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
@classabbyamp
Copy link
Member

It seems that f26f396 undid the version and checksum changes. Can you fix that and squash (as mentioned in my previous comment).

@classabbyamp
Copy link
Member

superceded by #37566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants