Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darktable: update to 4.0.0 #38336

Closed
wants to merge 15 commits into from
Closed

darktable: update to 4.0.0 #38336

wants to merge 15 commits into from

Conversation

ajtcode71
Copy link
Contributor

  • I tested the changes in this PR: YES
  • I built this PR locally for my native architecture, AMD64-LIBC
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64 (crossbuild)

@ajtcode71 ajtcode71 changed the title New Version 4.0.0 - Test compiled amd64 and aarch64. Darktable: New Version 4.0.0 - Test compiled amd64 and aarch64. Jul 28, 2022
@ajtcode71 ajtcode71 changed the title Darktable: New Version 4.0.0 - Test compiled amd64 and aarch64. darktable: update 4.0.0 - Test compiled amd64 and aarch64. Jul 28, 2022
@ajtcode71 ajtcode71 changed the title darktable: update 4.0.0 - Test compiled amd64 and aarch64. darktable: update 4.0.0 Jul 28, 2022
@ajtcode71 ajtcode71 changed the title darktable: update 4.0.0 darktable: update to 4.0.0 Jul 28, 2022
@CameronNemo
Copy link
Contributor

Squash commits and use the format darktable: update to 4.0.0 for the commit message.

@tranzystorekk
Copy link
Contributor

Seems you haven't updated the checksum, please run ./xbps-src pkg darktable to build your changes, and then test them if you can

@ajtcode71
Copy link
Contributor Author

For some reasons all xbps packages i xlint come up with following errors:
grep: zstd-1.5.2_1.x86_64.xbps: binary file matches
grep: zstd-1.5.2_1.x86_64.xbps: binary file matches
grep: zstd-1.5.2_1.x86_64.xbps: binary file matches
grep: zstd-1.5.2_1.x86_64.xbps: binary file matches
grep: zstd-1.5.2_1.x86_64.xbps: binary file matches
zstd-1.5.2_1.x86_64.xbps: 'homepage' missing!
zstd-1.5.2_1.x86_64.xbps: 'license' missing!
zstd-1.5.2_1.x86_64.xbps: 'maintainer' missing!
zstd-1.5.2_1.x86_64.xbps: 'pkgname' missing!
zstd-1.5.2_1.x86_64.xbps: 'revision' missing!
zstd-1.5.2_1.x86_64.xbps: 'short_desc' missing!
zstd-1.5.2_1.x86_64.xbps: 'version' missing!
zstd-1.5.2_1.x86_64.xbps:1: Header should be: # Template file for ''
zstd-1.5.2_1.x86_64.xbps:1758: File does not end with newline character

These are will packages that I havent built... My Darktable 4 template is as peer the 3.8 template will the change to version number and checksum..
All the fields that are coming back as missing are in the template...
Any ideas?

@CameronNemo
Copy link
Contributor

@ajtcode71 you run xlint on the template file, not the .xbps file

@ajtcode71
Copy link
Contributor Author

@CameronNemo - Ok stupid me (first time - can u tell?).. Xlint is not showing any errors at my end.. Yet the xlint test is complaining about 'subject'.
Do i need to do anything else... or just wait for approval to get it merged?

@abenson
Copy link
Contributor

abenson commented Aug 5, 2022

'subject' refers to your commit message. Squash the commits and make sure the commit message matches what you put as the title for the PR.

@lemmi
Copy link
Member

lemmi commented Aug 9, 2022

So, I haven't updated the package to 4.0.0 because things tend to break on major versions with darktable. I have 4.0.0 running locally, but there are hand full of small issues I didn't want everyone else to experience. I'd rather wait for a 4.0.1.

Sorry I didn't see this earlier. Please @ me next time.

@ajtcode71
Copy link
Contributor Author

ajtcode71 commented Aug 10, 2022

So, I haven't updated the package to 4.0.0 because things tend to break on major versions with darktable. I have 4.0.0 running locally, but there are hand full of small issues I didn't want everyone else to experience. I'd rather wait for a 4.0.1.

Sorry I didn't see this earlier. Please @ me next time.
@lemmi
Ok no problem.. Should I close this PR?

@paper42
Copy link
Member

paper42 commented Aug 10, 2022

This PR touches unrelated files, please fix that and make sure that it contains only one commit with the correct commit message

@lemmi
Copy link
Member

lemmi commented Aug 11, 2022

@ajtcode71 If you don't mind, I'd rather have this closed. It's also missing the lensfun update to go along side. I usually keep an eye on darktable, as regularly use it myself.

I pushed what I use to my branches, if you want to build it locally:
https://github.com/lemmi/void-packages/tree/darktable
https://github.com/lemmi/void-packages/tree/lensfun

Couple of issues I had, that held up the update:

  • segfaults on website export
  • avif image support still not working
  • random crashes I wasn't able to reproduce

Sorry I didn't catch this earlier and if this caused unnecessary work for you.

@lemmi lemmi closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants