-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: zsh-fast-syntax-highlighting-1.55 #38519
New package: zsh-fast-syntax-highlighting-1.55 #38519
Conversation
I think it might be more appropriate to use the provided Makefile to install the files to destdir. |
I don't see a Makefile in the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda meh on adding this, but there are similar scripts in the repos so maybe it could be added
|
||
do_install() { | ||
vmkdir usr/share/zsh/plugins/${pkgname} | ||
vcopy . usr/share/zsh/plugins/${pkgname} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/void-linux/void-packages/runs/7713259385?check_suite_focus=true#step:8:9
I don't think many of these files should be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure which are necessary files to copy.
f8fdc39
to
7991fec
Compare
4e728aa
to
cd329de
Compare
Update srcpkgs/zsh-fast-syntax-highlighting/template Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com> Update srcpkgs/zsh-fast-syntax-highlighting/template Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
37cd5f9
to
34d35d1
Compare
Sorry, I was looking at a wrong repo. It's unfortunate that there's no installation procedure. This might be useful. |
why its copying files to |
This has been attempted before: #33738. There were some weird bugs with chromas when installing system-wide. |
Testing the changes