Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: zsh-fast-syntax-highlighting-1.55 #38519

Conversation

akhiljalagam
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@classabbyamp classabbyamp added the new-package This PR adds a new package label Aug 7, 2022
@meator
Copy link
Contributor

meator commented Aug 7, 2022

I think it might be more appropriate to use the provided Makefile to install the files to destdir.

@akhiljalagam
Copy link
Contributor Author

I think it might be more appropriate to use the provided Makefile to install the files to destdir.

I don't see a Makefile in the repo.

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda meh on adding this, but there are similar scripts in the repos so maybe it could be added

srcpkgs/zsh-fast-syntax-highlighting/template Outdated Show resolved Hide resolved
srcpkgs/zsh-fast-syntax-highlighting/template Outdated Show resolved Hide resolved

do_install() {
vmkdir usr/share/zsh/plugins/${pkgname}
vcopy . usr/share/zsh/plugins/${pkgname}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure which are necessary files to copy.

@akhiljalagam akhiljalagam force-pushed the zsh-fast-syntax-highlighting branch 2 times, most recently from f8fdc39 to 7991fec Compare August 7, 2022 14:03
@akhiljalagam akhiljalagam force-pushed the zsh-fast-syntax-highlighting branch 2 times, most recently from 4e728aa to cd329de Compare August 7, 2022 14:29
Update srcpkgs/zsh-fast-syntax-highlighting/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>

Update srcpkgs/zsh-fast-syntax-highlighting/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
@meator
Copy link
Contributor

meator commented Aug 7, 2022

I think it might be more appropriate to use the provided Makefile to install the files to destdir.

I don't see a Makefile in the repo.

Sorry, I was looking at a wrong repo. It's unfortunate that there's no installation procedure. This might be useful.

@akhiljalagam
Copy link
Contributor Author

I think it might be more appropriate to use the provided Makefile to install the files to destdir.

I don't see a Makefile in the repo.

Sorry, I was looking at a wrong repo. It's unfortunate that there's no installation procedure. This might be useful.

why its copying files to $out/share/zsh/site-functions ? it should be /usr/share/zsh/plugins/zsh-fast-syntax-highlighting/ right ?

@cinerea0
Copy link
Contributor

cinerea0 commented Aug 8, 2022

This has been attempted before: #33738. There were some weird bugs with chromas when installing system-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants