Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goocanvas: update to 3.0.0. #39647

Closed
wants to merge 1 commit into from
Closed

Conversation

Wesley-Chan
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86-64-musl)

@Wesley-Chan
Copy link
Contributor Author

The failure in CI is due to this package: gpredict

It specifically requires goocanvas 2 in configure.ac, but as discussed in this issue, gpredict can use goocanvas 3 as well. Changes to adapt to it was also merged into its master but gpredict has no new version released after that change.

In our case, it is one package that is blocking our advancement. Is the normal way to resolve conflicts to make a newer version of goocanvas in Void Linux, or make custom patch to gpredict?

Please advice. Thank you very much.

@classabbyamp
Copy link
Member

if you can find the upstream commit(s)/pr that added goocanvas3 support for gpredict, you can export it as a patch by adding .patch to the url and download it to srcpkgs/gpredict/patches

@classabbyamp
Copy link
Member

classabbyamp commented Oct 3, 2022

looking into this more, perl-GooCanvas2 is the only other package that depends on goocanvas, so I think we should stay on goocanvas 2.x for now.

@Wesley-Chan
Copy link
Contributor Author

Hey, @classabbyamp. Thank you for your quick reply.

Sorry, I don't quite understand what you meant by "perl-GooCanvas2 is the only other package that depends on goocanvas". Doesn't gpredict also depend on goocanvas by linking to it?

The motivation of mine to update goocanvas is to bring Akira to Void, which does depend on goocanvas 3. If I understand correctly, if other packages like gpredict or perl-Goocanvas2 refuse to move on, Akira could never land on Void Linux, right?

Thank you very much.

P.S. How do I verify the GitHub action Verify repository state locally? Is it documented anywhere? Thanks again.

@classabbyamp
Copy link
Member

Sorry, I don't quite understand what you meant by "perl-GooCanvas2 is the only other package that depends on goocanvas". Doesn't gpredict also depend on goocanvas by linking to it?

only package other than gpredict is what I meant

The motivation of mine to update goocanvas is to bring Akira to Void, which does depend on goocanvas 3. If I understand correctly, if other packages like gpredict or perl-Goocanvas2 refuse to move on, Akira could never land on Void Linux, right?

in this case, we'd want to have a versioned package for the time being, like goocanvas2 and goocanvas. however, it seems that akira removed goocanvas? (akiraux/Akira#652)

How do I verify the GitHub action Verify repository state locally? Is it documented anywhere?

that ci step:

- name: Verify repository state
run: |
(
here="$(pwd)"
cd /
"$here/common/travis/check-install.sh" "$BOOTSTRAP" "$ARCH"
)

runs this script:
https://github.com/void-linux/void-packages/blob/master/common/travis/check-install.sh
I would not recommend running it locally outside of a container.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@newbluemoon
Copy link
Contributor

There is also #31159 which worked for me (i.e. the pre_configure-fix). I tested it with all depending packages just didn’t pursue it any further, because there didn’t seem to be much interest at that time. ;)

@github-actions github-actions bot removed the Stale label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 4, 2023
@github-actions github-actions bot closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants