-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goocanvas: update to 3.0.0. #39647
goocanvas: update to 3.0.0. #39647
Conversation
The failure in CI is due to this package: gpredict It specifically requires goocanvas 2 in configure.ac, but as discussed in this issue, gpredict can use goocanvas 3 as well. Changes to adapt to it was also merged into its master but gpredict has no new version released after that change. In our case, it is one package that is blocking our advancement. Is the normal way to resolve conflicts to make a newer version of goocanvas in Void Linux, or make custom patch to gpredict? Please advice. Thank you very much. |
if you can find the upstream commit(s)/pr that added goocanvas3 support for gpredict, you can export it as a patch by adding |
looking into this more, |
Hey, @classabbyamp. Thank you for your quick reply. Sorry, I don't quite understand what you meant by " The motivation of mine to update goocanvas is to bring Akira to Void, which does depend on goocanvas 3. If I understand correctly, if other packages like Thank you very much. P.S. How do I verify the GitHub action |
only package other than gpredict is what I meant
in this case, we'd want to have a versioned package for the time being, like
that ci step: void-packages/.github/workflows/build.yaml Lines 120 to 126 in 2cb7f28
runs this script: https://github.com/void-linux/void-packages/blob/master/common/travis/check-install.sh I would not recommend running it locally outside of a container. |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
There is also #31159 which worked for me (i.e. the |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
Local build testing