Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

support goocanvas 3 #246

Closed
chenrui333 opened this issue Jan 19, 2021 · 5 comments
Closed

support goocanvas 3 #246

chenrui333 opened this issue Jan 19, 2021 · 5 comments

Comments

@chenrui333
Copy link

chenrui333 commented Jan 19, 2021

馃憢 it looks like current gpredict 2.2.1 only supports goocanvas 2

configure: error: Gpredict requires libgoocanvas-2.0-dev

relates to Homebrew/homebrew-core#69285

@csete
Copy link
Owner

csete commented Jan 23, 2021

As far as I can see, goocanvas3 has just been released a week ago, so yeah...

I will take a look and see whether it is just a version change or whether there is API/ABI breakage that requires changes in the code. If it is just a version change, we can probably easily support both version 2 and 3. However, in if breaks API or ABI, you should probably prepare to ship both version 2 and 3 and give applications time to migrate properly.

@chenrui333
Copy link
Author

Sounds good. Thanks @csete!

csete added a commit that referenced this issue Feb 20, 2021
If GooCanvas 2 is not available, check for version 3.
Issue #246.
@csete
Copy link
Owner

csete commented Feb 20, 2021

@chenrui333 As far as I could see from you patch (PR #251), Gpredict could build against GooCanvas 3 without changes to the code. So I have updated the configure.ac to check for GooCanvas 3 if GooCanvas 2 is not available. Could you please check the current HEAD and see if it works like this? Thanks.

@LongnoseRob
Copy link
Contributor

LongnoseRob commented Mar 21, 2021

Just a short feedback,
I can confirm this fix on HEAD works, atleast on archlinumx-arm with goocanvas 3.0.0-1.
No issue with compiling with this version of goocanvas

@csete
Copy link
Owner

csete commented May 8, 2021

Thanks, @LongnoseRob!

@csete csete closed this as completed May 8, 2021
spsvihla pushed a commit to lasp/gpredict that referenced this issue Nov 29, 2022
Fix CubeSX-Sirius-HSE.yml carrier frequency and KSU_CubeSat.yml baudrate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants