Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: fix strverscmp comparison of digit sequence #41228

Closed
wants to merge 1 commit into from
Closed

musl: fix strverscmp comparison of digit sequence #41228

wants to merge 1 commit into from

Conversation

crtxcr
Copy link
Contributor

@crtxcr crtxcr commented Dec 21, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (n/a)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

The test in #41226 fails due to a bug in musl which causes strverscmp() to behave incorrectly and differently from glibc.

This PR applies an upstream patch to fix that behavior. After applying the patch, the failed test succeeds

@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 21, 2022

CC @Gottox

@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 22, 2022

Not sure why "Verify repository state" breaks

2022-12-21T23:16:06.6254426Z perl-5.36.0_1 install x86_64-musl https://repo-ci.voidlinux.org/current/musl 74756379 14757854
2022-12-21T23:16:06.6255023Z perl-pcsc-1.4.14_10 install x86_64-musl https://repo-ci.voidlinux.org/current/musl 137135 33670
2022-12-21T23:16:07.0185811Z perl-rrdtool-1.7.2_13: broken, unresolvable shlib `libperl.so.5.36'

Doesn't seem it's related to this PR.

However, perl-rrdtool was revbumped in c789421 so dunno what's going on here

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 24, 2023
@github-actions github-actions bot closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant