Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrdtool: rebuild to fix unresolvable shlib, fix tests #41245

Merged
merged 1 commit into from
Dec 23, 2022
Merged

rrdtool: rebuild to fix unresolvable shlib, fix tests #41245

merged 1 commit into from
Dec 23, 2022

Conversation

crtxcr
Copy link
Contributor

@crtxcr crtxcr commented Dec 22, 2022

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

The test for #41228 fails with:

perl-rrdtool-1.7.2_13: broken, unresolvable shlib `libperl.so.5.36'

This can be reproduced by:

./xbps-src -m musl_temp binary-bootstrap x86_64-musl
./xbps-src -m musl_temp chroot
xbps-install perl-rrdtool

This is a due to missing "depends" on perl.

This PR simply adds perl to the dependecy

CC @Gottox

@paper42
Copy link
Member

paper42 commented Dec 22, 2022

This is not a proper solution, $shlib_requires is supposed to add perl to run_depends using the entry in common/shlibs. I don't know why it didn't, but just rebuilding the package helps.

@crtxcr crtxcr changed the title perl-rrdtool: Add missing "perl" dependency perl-rddtool: rebuild to fix unresolvable shlib Dec 22, 2022
@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 22, 2022

I have simply changed this PR to be a revbump then

Although the rddtool tests fail, they also failed before according to: #39463

@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 22, 2022

I've found an upstream patch to solve the failing error on musl and added "bc" so the "dc" command required by a test becomes available.

Forced-pushed these changes

@crtxcr crtxcr changed the title perl-rddtool: rebuild to fix unresolvable shlib rrdtool: rebuild to fix unresolvable shlib, fix tests Dec 22, 2022
@paper42
Copy link
Member

paper42 commented Dec 23, 2022

awesome, but please put it to checkdepends if it's only needed for tests

@sgn
Copy link
Member

sgn commented Dec 23, 2022

This is not a proper solution, $shlib_requires is supposed to add perl to run_depends using the entry in common/shlibs. I don't know why it didn't, but just rebuilding the package helps.

rebuild package works because of #40412

@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 23, 2022

awesome, but please put it to checkdepends if it's only needed for tests

I forgot about it, thx. done!

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed python3-rrdtool is missing a dependency on python3, could you add that? That's not a shared library dependency, so it won't be detected.

Rebuild to get rid of error:
"perl-rrdtool-1.7.2_13: broken, unresolvable shlib `libperl.so.5.36'"

A previous revbump didn't do it because #40412 wasn't merged yet.

Add "bc" to checkdepends so a test doesn't fail.

Add upstream patch so test does not fail on musl

Add python3 dependency for python3-rrdtool
@crtxcr
Copy link
Contributor Author

crtxcr commented Dec 23, 2022

I just noticed python3-rrdtool is missing a dependency on python3, could you add that?

Done

@paper42 paper42 merged commit e0bd54d into void-linux:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants