Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift: update (openssl3) #41967

Merged
merged 1 commit into from Jun 28, 2023
Merged

thrift: update (openssl3) #41967

merged 1 commit into from Jun 28, 2023

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Jan 30, 2023

  • I tested the changes in this PR: no
  • I built this PR locally for my native architecture, (x86_64-musl)

required to build with openssl3 #37681

@dkwo dkwo force-pushed the O3thrift branch 2 times, most recently from ff8a3af to 8aade36 Compare January 30, 2023 17:12
@dkwo
Copy link
Contributor Author

dkwo commented Jan 30, 2023

actually update it

srcpkgs/thrift/template Outdated Show resolved Hide resolved
@dkwo dkwo force-pushed the O3thrift branch 3 times, most recently from 427a380 to b42f89e Compare January 30, 2023 18:22
@dkwo dkwo changed the title thrift: update distfiles, bump for openssl thrift: update (openssl3) Jan 30, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your commit message header to thrift: update to 0.17.0, patch for openssl3.

There is also a sed command in the template which should be replaced to vsed, but I myself am not sure who ever build on ppc64* these days.

srcpkgs/thrift/template Outdated Show resolved Hide resolved
srcpkgs/thrift/template Outdated Show resolved Hide resolved
srcpkgs/thrift/template Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Feb 1, 2023

There is also a sed command in the template which should be replaced to vsed, but I myself am not sure who ever build on ppc64* these days.

I'll do as you say, but I did not check the ppc builds.

@dkwo dkwo force-pushed the O3thrift branch 2 times, most recently from 33490b7 to b6ea3e9 Compare February 1, 2023 16:35
@ghost
Copy link

ghost commented Feb 3, 2023

@Vaelatern, if you may?

@dkwo dkwo force-pushed the O3thrift branch 2 times, most recently from d1ba2cb to f84da68 Compare February 5, 2023 15:43
@dkwo dkwo requested review from Duncaen, a user and paper42 and removed request for Duncaen, a user and paper42 March 6, 2023 18:31
@dkwo
Copy link
Contributor Author

dkwo commented Jun 2, 2023

updated to 0.18, removed patches, now one glibc test fails:

17/44 Test #17: UnitTests ........................***Failed    1.32 sec
Running 60 test cases...
unknown location(0): fatal error: in "ToStringTest/locale_de_DE_floating_point_to_string": std::runtime_error: locale::facet::_S_create_c_locale name not valid
/builddir/thrift-0.18.1/lib/cpp/test/ToStringTest.cpp(57): last checkpoint: "locale_de_DE_floating_point_to_string" test entry
An error message from getaddrinfo on the console is expected:
Thrift: Fri Jun  2 15:23:52 2023 getaddrinfo() -> -2; Name or service not known

*** 1 failure is detected in the test module "thrift"

@dkwo
Copy link
Contributor Author

dkwo commented Jun 2, 2023

working now

@dkwo
Copy link
Contributor Author

dkwo commented Jun 28, 2023

@Duncaen Can this be merged?

@Bnyro
Copy link
Contributor

Bnyro commented Jun 28, 2023

(also addresses #42403)

@Duncaen Duncaen merged commit e0aefd7 into void-linux:master Jun 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants