Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: lsp-plugins-1.2.5 #42512

Merged
merged 2 commits into from
Jun 24, 2023
Merged

New package: lsp-plugins-1.2.5 #42512

merged 2 commits into from
Jun 24, 2023

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Feb 28, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@subnut subnut marked this pull request as draft February 28, 2023 21:23
@subnut subnut marked this pull request as ready for review February 28, 2023 21:27
@subnut
Copy link
Contributor Author

subnut commented Feb 28, 2023

Fixes #32991

@paper42 paper42 added the new-package This PR adds a new package label Feb 28, 2023
@subnut
Copy link
Contributor Author

subnut commented Mar 1, 2023

According to the build logs, the build is failing on musl due to our outdated musl not having the qsort_r function, which was introduced in musl 1.2.3

@paper42 What should be done? Should I set archs="~*-musl"?

@subnut subnut marked this pull request as draft March 1, 2023 18:29
@paper42
Copy link
Member

paper42 commented Mar 1, 2023

According to the build logs, the build is failing on musl due to our outdated musl not having the qsort_r function, which was introduced in musl 1.2.3

@paper42 What should be done? Should I set archs="~*-musl"?

definitely no, either you can fix it with a patch or wait for #42425

@subnut
Copy link
Contributor Author

subnut commented Mar 1, 2023

Okay, I'll wait for #42425

@subnut subnut marked this pull request as ready for review March 10, 2023 03:10
triallax
triallax reviewed Mar 13, 2023
View reviewed changes
srcpkgs/lv2/template Outdated Show resolved Hide resolved
triallax
triallax reviewed Mar 13, 2023
View reviewed changes
srcpkgs/lv2/template Outdated Show resolved Hide resolved
zen0bit
zen0bit suggested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@zen0bit zen0bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version 1.2.6 builded at tested on glibc 64bit...
(used changes of lv2...)

srcpkgs/lsp-plugins/template Outdated Show resolved Hide resolved
srcpkgs/lsp-plugins/template Outdated Show resolved Hide resolved
@subnut subnut marked this pull request as draft April 12, 2023 04:46
@subnut subnut marked this pull request as ready for review April 12, 2023 04:49
@Duncaen Duncaen merged commit 3e88382 into void-linux:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triallax triallax triallax left review comments

@zen0bit zen0bit zen0bit requested changes

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@subnut @paper42 @zen0bit @triallax @Duncaen