Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: singularity-3.11.0 #42592

Closed
wants to merge 1 commit into from
Closed

Conversation

snwnde
Copy link

@snwnde snwnde commented Mar 4, 2023

This is based on the work of @olafmersmann, #28129.
When merged, this should close #8135.

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Mar 4, 2023
Comment on lines +5 to +7
build_style=go
go_import_path=github.com/sylabs.io/singularity
go_mod_mode=vendor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set the build_style when you override all the steps?

Copy link
Author

@snwnde snwnde Mar 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to do minimal change to #28129, and I agree there is no need to set it.

Edit: actually, this is needed to get correct go env when doing cross compilation.

@snwnde snwnde changed the title New package: singularity-3.11.0 [WIP] New package: singularity-3.11.0 Mar 6, 2023
@snwnde snwnde force-pushed the singularity branch 3 times, most recently from 9f92757 to 7043bac Compare March 6, 2023 21:40
@snwnde
Copy link
Author

snwnde commented Mar 6, 2023

Caution and tweaks for cross compilation.

  • The configuration script ./mconf needs GOARCH set to the host architecture to run.
  • ./mconf tries to build and run some test codes. While building can be done with another architecture, the execution is not possible AFAIK. See this line. We have to remove this block from the check script.
  • We can remove that block to proceed and get a Makefile. A Makefile target called codegen again needs host GOARCH.
  • Cross compilation with cgo requires specifying -extld in go ldflags.

This does not solve all the problems, and I am unwilling to go down the rabbit hole. If someone is interested in looking at this, this template file should be a good start.

@classabbyamp Could we make this an x86-64 only package? Given that binaries released by upstream are also only built for this architecture (https://github.com/sylabs/singularity/releases). If a native build for aarch64 can be tested, this can also be included.

@snwnde snwnde force-pushed the singularity branch 3 times, most recently from 065d8e1 to c8dd70d Compare March 7, 2023 19:01
@snwnde snwnde changed the title [WIP] New package: singularity-3.11.0 New package: singularity-3.11.0 Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 6, 2023
@github-actions github-actions bot closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Singularity
2 participants