New package: singularity-3.7.1 #28129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafmersmann
force-pushed
the
singularity
branch
from
afdc5a0
to
962213d
Compare
ericonr
reviewed
Jan 26, 2021
olafmersmann
force-pushed
the
singularity
branch
4 times, most recently
from
34c2809
to
7c1adfc
Compare
olafmersmann
changed the title
Johnnynator
requested changes
Jan 30, 2021
olafmersmann
force-pushed
the
singularity
branch
from
7c1adfc
to
3595910
Compare
ericonr
reviewed
Jan 31, 2021
Comment on lines
+3
to
+7
| if [ "$(readlink -f . 2>/dev/null || echo .)" != "/" ]; then | ||
| exit 1 | ||
| else | ||
| chown root:_singularity usr/libexec/singularity/bin/starter-suid | ||
| chmod 4755 usr/libexec/singularity/bin/starter-suid |
There was a problem hiding this comment.
Isn't an explicit failure here pretty bad? I think XBPS stops updates if you die with failure (instead of returning 0).
There was a problem hiding this comment.
True that. Didn't think of that.
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?
The tests require
sudo, so they are disabled. To start an interactive Alpine container, run installationDoes it build and run successfully?