-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apr-util: update to 1.6.3 #42636
apr-util: update to 1.6.3 #42636
Conversation
The test suite seems to fail randomly even on glibc (cannot reproduce that on my local machine though) so may have to disable it completely again. |
I feel like I'm in over my head on this one.
Is it really correct that the host linker is used rather than the one from the crosscompiler? |
0676b4b
to
a638a45
Compare
configure script complains of:
which may be related. The options are set as:
|
If I look into the libtool script without the commit i get:
which allows the linker to be overridden by the environment. With the commit i get:
which sets the linker unconditionally. So the problematic part of the commit is probably:
I'll revert that part only and see if it still builds ok. |
5e22e58
to
ae53fdf
Compare
The arm libtool package should be consistent with the x86_64 libtool package, I'm not sure why this change should be made for one but not the other (especially if that patch breaks building C++ applications like ntl). If you need |
That worked, thanks! This should be mostly ready now. Though I don't use this package directly so additional testing would be appreciated. |
Use archive.apache.org instead of downloads.apache.org as the former does not delete outdated versions. |
I'm seeing the same |
That just means that those options aren't being used. Both apr-util and coreutils the package doesn't perform In other words, you shouldn't need to do anything. |
You could try It's probably more likely the failure is a result of the CI restricting the inotify feature if it doesn't happen to you locally. |
It is not a failure, it is a warning (one that can be safely ignored in this case). |
I also referred to the test failure in my first sentence, sorry if I was unclear. |
Ah, my bad. |
Thank you, then I'll ignore the warning. |
Also, @klarasm here is a better solution without the libtool wrapdir thing: |
752f7c6
to
f6be57e
Compare
I may have overlooked some vseds when applying... |
The vsed should be |
No worries. The 32bit arm crossbuilds seems to fail unrelated to this, though. There seems to be a |
f6be57e
to
def2f6c
Compare
You can fix that by using |
def2f6c
to
f69dd98
Compare
That did it, thanks! |
f69dd98
to
3e78d49
Compare
initially failed to download distfiles when revbumping, though that has been fixed separately. - remove upstreamed patch - switch to vsed - cross-compilation fix (thanks @oreo639)
3e78d49
to
6fcbf15
Compare
Is anything preventing merge in this PR? |
That is up to the maintainers. You can try asking for a review on the IRC (politely ofc) |
Failed to download distfiles when revbumping in #41948
Testing the changes
Local build testing