Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: bash-language-server-4.9.1 #42818

Merged
merged 1 commit into from
May 10, 2023

Conversation

sirkhancision
Copy link
Contributor

@sirkhancision sirkhancision commented Mar 17, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures:
    • i686
    • x86_64-musl
    • aarch64

@sirkhancision
Copy link
Contributor Author

This also resolves #38606

@icp1994
Copy link
Contributor

icp1994 commented Mar 17, 2023

Unfortunate to have a language server for bash being available only under i686 & x86_64.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Mar 17, 2023
@classabbyamp
Copy link
Member

how did you build this for x86_64-musl when archs="i686 x86_64"?

@classabbyamp
Copy link
Member

Unfortunate to have a language server for bash being available only under i686 & x86_64.

cross-compiles fine for me 🤷‍♀️

srcpkgs/bash-language-server/template Outdated Show resolved Hide resolved
srcpkgs/bash-language-server/template Outdated Show resolved Hide resolved
@sirkhancision
Copy link
Contributor Author

sirkhancision commented Mar 17, 2023

how did you build this for x86_64-musl when archs="i686 x86_64"?

My bad, I had built it before restricting the architectures, and I thought x86_64 meant both glibc and musl. It's corrected now, and limiting i686 to glibc, as building it in i686-musl fails for me.

@classabbyamp
Copy link
Member

i686-musl doesn't really exist, so don't worry about it.

[archname] means glibc, [archname]-musl means musl, [archname]-* is both

@sirkhancision
Copy link
Contributor Author

i686-musl doesn't really exist, so don't worry about it.

[archname] means glibc, [archname]-musl means musl, [archname]-* is both

I rewrote it as x86_64-* but it's now saying that the package can't be built for x86_64, any ideas as to why that is happening now?

@classabbyamp
Copy link
Member

sorry x86_64* (no dash), but you shouldn't need to specify the archs, it should work on all of them

@sirkhancision
Copy link
Contributor Author

Unfortunate to have a language server for bash being available only under i686 & x86_64.

cross-compiles fine for me woman_shrugging

To me, it says:
=> ERROR: nodejs-16.19.0_1: cannot be cross compiled...

=> ERROR: nodejs-16.19.0_1: host and target must have the same pointer size

@classabbyamp
Copy link
Member

it works on aarch64, but you shouldn't limit the arch because of that error: someone can still build it for themselves either natively or cross from 32bit

@sirkhancision
Copy link
Contributor Author

it works on aarch64, but you shouldn't limit the arch because of that error: someone can still build it for themselves either natively or cross from 32bit

Indeed, it built fine on aarch64. Thanks for the help with these packages, and the tips, you're awesome!

I think it might be fine, now.

@tjkirch
Copy link
Contributor

tjkirch commented May 9, 2023

Thanks @sirkhancision! This is working great for me from a local build. I also tested with bash-language-server 4.9.1 and it worked fine, in case you want to update the PR.

diff --git a/srcpkgs/bash-language-server/template b/srcpkgs/bash-language-server/template
index 02fcb44dfb..5c8f99cdd4 100644
--- a/srcpkgs/bash-language-server/template
+++ b/srcpkgs/bash-language-server/template
@@ -1,6 +1,6 @@
 # Template file for 'bash-language-server'
 pkgname=bash-language-server
-version=4.8.3
+version=4.9.1
 revision=1
 hostmakedepends="jq yarn"
 depends="nodejs"
@@ -9,7 +9,7 @@ maintainer="sirkhancision <jsantiago12tone@gmail.com>"
 license="MIT"
 homepage="https://github.com/bash-lsp/bash-language-server"
 distfiles="https://github.com/bash-lsp/bash-language-server/archive/refs/tags/server-${version}.tar.gz"
-checksum=a6c367e19a007b889f59fa7aa6a8c4fb0fae83fbfcc928e7a8f4366015dedbd6
+checksum=eef93c1167394fb01fc300c5b8c326fd9362dd3118a1e075549342e24e9d6e5c
 
 do_build() {
 	yarn

@sirkhancision sirkhancision changed the title New package: bash-language-server-4.8.3 New package: bash-language-server-4.9.1 May 9, 2023
@classabbyamp classabbyamp merged commit a5274af into void-linux:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants