-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: bash-language-server-4.9.1 #42818
New package: bash-language-server-4.9.1 #42818
Conversation
This also resolves #38606 |
Unfortunate to have a language server for bash being available only under |
how did you build this for x86_64-musl when |
5573f69
to
b933346
Compare
cross-compiles fine for me 🤷♀️ |
My bad, I had built it before restricting the architectures, and I thought x86_64 meant both glibc and musl. It's corrected now, and limiting i686 to glibc, as building it in i686-musl fails for me. |
i686-musl doesn't really exist, so don't worry about it.
|
I rewrote it as |
sorry |
To me, it says:
|
it works on aarch64, but you shouldn't limit the arch because of that error: someone can still build it for themselves either natively or cross from 32bit |
b933346
to
93fb792
Compare
Indeed, it built fine on aarch64. Thanks for the help with these packages, and the tips, you're awesome! I think it might be fine, now. |
Thanks @sirkhancision! This is working great for me from a local build. I also tested with bash-language-server 4.9.1 and it worked fine, in case you want to update the PR. diff --git a/srcpkgs/bash-language-server/template b/srcpkgs/bash-language-server/template
index 02fcb44dfb..5c8f99cdd4 100644
--- a/srcpkgs/bash-language-server/template
+++ b/srcpkgs/bash-language-server/template
@@ -1,6 +1,6 @@
# Template file for 'bash-language-server'
pkgname=bash-language-server
-version=4.8.3
+version=4.9.1
revision=1
hostmakedepends="jq yarn"
depends="nodejs"
@@ -9,7 +9,7 @@ maintainer="sirkhancision <jsantiago12tone@gmail.com>"
license="MIT"
homepage="https://github.com/bash-lsp/bash-language-server"
distfiles="https://github.com/bash-lsp/bash-language-server/archive/refs/tags/server-${version}.tar.gz"
-checksum=a6c367e19a007b889f59fa7aa6a8c4fb0fae83fbfcc928e7a8f4366015dedbd6
+checksum=eef93c1167394fb01fc300c5b8c326fd9362dd3118a1e075549342e24e9d6e5c
do_build() {
yarn |
93fb792
to
ca0f2b5
Compare
Testing the changes
New package
Local build testing