Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skarnet update #43583

Closed
wants to merge 11 commits into from
Closed

Skarnet update #43583

wants to merge 11 commits into from

Conversation

mobinmob
Copy link
Contributor

@mobinmob mobinmob commented Apr 23, 2023 •
edited
Loading

Testing the changes

  • I tested the changes in this PR: YES

--

  • Update to skarnet packages and manpages.
  • A new package for s6-rc-man-pages is added and the man pages repos are now hosted on sourcehut, so homepage and distfiles are changed.

@mobinmob
Copy link
Contributor Author

mobinmob commented May 1, 2023

@Duncaen
Copy link
Member

Duncaen commented Jun 14, 2023

I don't like that we start vendoring random configuration files.

@Duncaen
Copy link
Member

Duncaen commented Jun 14, 2023

I would prefer if you do changes like that in separate PRs from just the bulk updates.

@mobinmob
Copy link
Contributor Author

mobinmob commented Jul 1, 2023 •
edited
Loading

I would prefer if you do changes like that in separate PRs from just the bulk updates.

I agree, but there should be a way to have some configuration files that are tested, even if they are not endorsed in some way for the distribution. This was tested by @dkwo. I removed it and corrected the template and service to account for it. Maybe installing the file with vdoc as mdev.conf.sample and making clear in a comment that this is offered as an example will be acceptable?

@mobinmob
Copy link
Contributor Author

mobinmob commented Jul 1, 2023

  • Rebased on master.
  • Fixes (many thanks for the review @Duncaen !)
  • Added --enable-pedantic-posix to the execline configure_args.

@mobinmob
mdevd: add service.
a12b4f3 
Thanks to dkwo for the initial work and Duncaen for enhancements.
@mobinmob
Copy link
Contributor Author

mobinmob commented Jul 1, 2023 •
edited
Loading

  • Added --enable-pedantic-posix to the execline configure_args.

In some (rare) cases the execline-cd is called instead of the shell internal command and that works in a slightly different way.

@dkwo
Copy link
Contributor

dkwo commented Jul 1, 2023 •
edited
Loading

I tested that config for mdev a while ago, but dropping it or including as vdoc seems also fine.
Note that without a config it is rather useless.

@mobinmob
Copy link
Contributor Author

mobinmob commented Jul 1, 2023

I tested that config for mdev a while ago, but dropping it or including as vdoc seems also fine.
Note that without a config it is rather useless.

I think that mdevd has a pretty clear log message for a missing configuration file, so I hope a sample config under the usual place for documentation will be helpful.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 30, 2023
@mobinmob
Copy link
Contributor Author

bump...

@github-actions github-actions bot removed the Stale label Oct 1, 2023
@mobinmob
Copy link
Contributor Author

Superseeded by #47177 .

@mobinmob mobinmob closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duncaen Duncaen Duncaen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobinmob @Duncaen @dkwo