element-desktop: Updated launch script with electron24 #43885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you make the commit message more descriptive (like the PR title)? |
Of course. |
|
@classabbyamp I don't understand why it's taking so long.. Maybe because the template in void-packages has been updated to 24.3 but it's not available in the repos yet? |
|
correct, it's still being built |
|
Oh wow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for editing the Element startup script:
in the PR I did to update Element (to version 1.11.31 - #43861) I changed the Electron dependencies from version 19 to 24, without updating the startup script with the relevant new version of Electron.
This PR is to fix this error.
Testing the changes
Local build testing