-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-style/python3-pep517: use a generic glob for wheels #44071
Conversation
Also: do not compile bytecode in `do_install()` since it will be removed in `post_install()`.
build-style/python3-pep517: use a generic glob for wheels, refactor Co-authored-by: Gonzalo Tornaría <tornaria@cmat.edu.uy> Co-authored-by: Andrew J. Hesford <ajh@sideband.org>
Now that the wheel glob in do_check and do_install is more generic, there is no longer a need to override the default behavior.
I have made a couple of changes:
Please confirm that you are OK with these changes, and we can squash down my alterations before merge. |
Thanks; I dropped the synapse fix. |
LGTM, thanks! I made a minor suggestion so the style in |
Also: do not compile bytecode in `do_install()` since it will be removed in `post_install()`. Co-authored-by: Gonzalo Tornaría <tornaria@cmat.edu.uy> Co-authored-by: Andrew J. Hesford <ajh@sideband.org> Closes: void-linux#44071.
Also: do not compile bytecode in `do_install()` since it will be removed in `post_install()`. Co-authored-by: Gonzalo Tornaría <tornaria@cmat.edu.uy> Co-authored-by: Andrew J. Hesford <ajh@sideband.org> Closes: void-linux#44071.
We replace the current glob of
"dist/${wheelbase//-/_}-${version}-*-*-*.whl"
for a much simplerdist/*.whl
. The former is inconvenient sincewheelbase="${pkgname#python3-}"
is most of the time correct but often not, and fixing that in a different way seems more complicated than this solution.Since we only run
python -m build
once, we should have only one wheel, so trying to be more specific doesn't seem useful. Nevertheless, this can still be overriden viamake_install_target
as before but hopefully it won't ever be necessary.Note that several packages that currently need to set
make_install_target
for this purposes will now work out of the box.If this is accepted I can have a look at those pkgs and clean up the override once it's no longer necessary.
Testing the changes
I built all 150 packages that use pep517 as obtained by:
All of them succeed except for two that fail for unrelated reasons (
python3-xcffib
andsynapse
).I also included a minor unrelated change: do not compile bytecode in
do_install()
since it will be removed inpost_install()
.CC: @ahesford @icp1994