Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Logseq-0.10.8 #44337

Closed
wants to merge 1 commit into from
Closed

New package: Logseq-0.10.8 #44337

wants to merge 1 commit into from

Conversation

shnaps
Copy link

@shnaps shnaps commented Jun 9, 2023 •
edited
Loading

Testing the changes

  • I tested the changes in this PR: yes

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jun 9, 2023
@shnaps shnaps force-pushed the Logseq branch 2 times, most recently from 67afd84 to efb30b2 Compare June 10, 2023 07:31
@unrealjo
Copy link
Contributor

@shnaps It still in Beta Testing ?!
@classabbyamp I'm not sure if these packages can be considered stable. The situation may be similar to FreeTube.

@classabbyamp
Copy link
Member

why ping me specifically?

@classabbyamp
Copy link
Member

but why address it to me specifically? all i did was label the pr

classabbyamp
classabbyamp reviewed Jun 11, 2023
View reviewed changes
srcpkgs/Logseq/template Outdated
Comment on lines 16 to 19
vinstall "${XBPS_BUILDDIR}/${pkgname}-${version}/resources/app/icons/logseq.png" 644 usr/share/pixmaps logseq.png
vcopy "${XBPS_BUILDDIR}/${pkgname}-${version}" usr/lib/Logseq
vlicense "${XBPS_BUILDDIR}/${pkgname}-${version}/LICENSE"
vlicense "${XBPS_BUILDDIR}/${pkgname}-${version}/LICENSES.chromium.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first argument of most of the v* functions are relative to $wrksrc, which is $XBPS_BUILDDIR/$pkgname-$version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you suggest here. Could you tell me more?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vlicense "${XBPS_BUILDDIR}/${pkgname}-${version}/LICENSE" should be vlicense LICENSE

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this template to compile from sources but seems like it requires openssl 3.

SONAME: libssl.so.3 <-> UNKNOWN PKG PLEASE FIX!
SONAME: libcrypto.so.3 <-> UNKNOWN PKG PLEASE FIX!

Is there any way I can fix it until #37681 is merged?

srcpkgs/Logseq/template Outdated Show resolved Hide resolved
@shnaps shnaps changed the title New package: Logseq-0.9.8 [WIP] New package: Logseq-0.9.8 Jun 19, 2023
@shnaps shnaps changed the title [WIP] New package: Logseq-0.9.8 [WIP] New package: Logseq-0.9.9 Jun 19, 2023
@classabbyamp classabbyamp added the electron 🤮 Electron package request label Jun 19, 2023
@shnaps shnaps force-pushed the Logseq branch 3 times, most recently from 65a48ba to 8f850c0 Compare June 19, 2023 20:16
@shnaps shnaps changed the title [WIP] New package: Logseq-0.9.9 [WIP] New package: Logseq-0.9.8 Jun 19, 2023
@shnaps
Copy link
Author

shnaps commented Jun 19, 2023

Confirmed at the IRC that I won't be able to use 0.9.9 unless #37681 is merged into void packages. Stopped at 0.9.8 for now, will come back to update later.

@shnaps shnaps changed the title [WIP] New package: Logseq-0.9.8 New package: Logseq-0.9.8 Jun 19, 2023
@shnaps shnaps force-pushed the Logseq branch 2 times, most recently from d008c61 to 4f97ce6 Compare June 20, 2023 00:23
@shnaps shnaps requested a review from classabbyamp June 21, 2023 01:23
@shnaps shnaps force-pushed the Logseq branch 3 times, most recently from 18a6e35 to fffc333 Compare August 10, 2023 02:57
@shnaps shnaps force-pushed the Logseq branch 2 times, most recently from 56e0b19 to e8fc4d4 Compare August 27, 2023 08:13
@shnaps shnaps changed the title New package: Logseq-0.9.8 New package: Logseq-0.9.15 Aug 27, 2023
@shnaps
Copy link
Author

shnaps commented Aug 27, 2023

@classabbyamp pr is ready for review again

@shnaps shnaps changed the title New package: Logseq-0.9.15 New package: Logseq-0.9.16 Sep 6, 2023
@shnaps shnaps force-pushed the Logseq branch 2 times, most recently from 6df4cdc to 33528ca Compare September 7, 2023 21:33
@shnaps shnaps changed the title New package: Logseq-0.9.16 New package: Logseq-0.9.17 Sep 7, 2023
@github-actions GitHub Actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 15, 2024
@github-actions github-actions bot closed this Jan 30, 2024
@gontcharovd
Copy link

Hello, @shnaps is the work to get Logseq into the Void packages repository still ongoing? Is there anything I can do to help?

@shnaps
Copy link
Author

shnaps commented Mar 26, 2024

Hello, @shnaps is the work to get Logseq into the Void packages repository still ongoing? Is there anything I can do to help?

Yeah, I keep my local template updated. I waited for the pr to be reviewed, but no one did that, so it went stale and closed. I can update it if needed.

@gontcharovd
Copy link

Yes, I'd like the update please. I don't want to use the Flatpak logseq

@shnaps
Copy link
Author

shnaps commented Apr 12, 2024

Yes, I'd like the update please. I don't want to use the Flatpak logseq

Maybe one of the maintainers could open this PR again. The branch itself is up to date and could be used for PR at any moment. @oreo639 @cinerea0 pinging you just in case, maybe you could help us.

@shnaps shnaps changed the title New package: Logseq-0.9.17 New package: Logseq-0.10.8 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classabbyamp classabbyamp Awaiting requested review from classabbyamp

Assignees
No one assigned
Labels
electron 🤮 Electron package request new-package This PR adds a new package Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shnaps @unrealjo @classabbyamp @gontcharovd