Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnamon 5.8.x #44590

Merged
merged 22 commits into from
Jul 31, 2023
Merged

Cinnamon 5.8.x #44590

merged 22 commits into from
Jul 31, 2023

Conversation

triallax
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly (I don't use Cinnamon but did briefly test the DE)

Testing from actual Cinnamon users would be appreciated.

srcpkgs/cjs/template Outdated Show resolved Hide resolved
@triallax triallax marked this pull request as draft June 30, 2023 16:24
@dmarto
Copy link
Contributor

dmarto commented Jul 5, 2023

@mhmdanas should I test this (I daily cinnamon), or should I wait for non-draft status?

@triallax
Copy link
Contributor Author

triallax commented Jul 5, 2023

@dmarto this should be fine to test. I've marked it as draft because of the lack of testing and because of the CI check failure on cjs.

@dmarto
Copy link
Contributor

dmarto commented Jul 7, 2023

Rebased on 14cd86c; built and running for close to an hour already, and will continue to use it.

My only request is to drop "touchegg" from depends as it is an optional dependency, and as one of the crazy people that daily uses a touchpad on a computer (not laptop), I also don't find it particularly good.

@triallax
Copy link
Contributor Author

Thanks for the feedback.

My only request is to drop "touchegg" from depends as it is an optional dependency, and as one of the crazy people that daily uses a touchpad on a computer (not laptop), I also don't find it particularly good.

Do you think adding it to cinnamon-all is a good idea? I added it because it was recommended in one of the package's changelogs (though I don't recall which one).

@dmarto
Copy link
Contributor

dmarto commented Jul 10, 2023

hah, I didn't know about cinnamon-all, I don't have it, but I guess it makes sense to include the dep there

@triallax
Copy link
Contributor Author

triallax commented Jul 21, 2023

@dmarto I pushed some more updates, can you please test again?

@triallax triallax force-pushed the cinnamon-5.8.1 branch 3 times, most recently from 40258f2 to 138b1fc Compare July 22, 2023 20:45
@dmarto
Copy link
Contributor

dmarto commented Jul 23, 2023

idk, what you changed, so here is what xbps updated based on 138b1fc

Name                       Action    Version           New version            Download size
cinnamon                   update    5.8.3_1           5.8.4_1                - 
cinnamon-control-center    update    5.8.1_1           5.8.2_1                - 
cinnamon-screensaver       update    5.8.0_1           5.8.1_1                - 
cinnamon-translations      update    5.8.1_1           5.8.2_1                - 
libcinnamon-control-center update    5.8.1_1           5.8.2_1                - 
muffin                     update    5.8.0_1           5.8.1_1                - 

will report back, in a day :)

edit: no issues found, all good here

@triallax
Copy link
Contributor Author

@dmarto thanks for testing. What remains at this point is fixing the cjs tests on musl; I opened a ticket for that.

@triallax triallax force-pushed the cinnamon-5.8.1 branch 2 times, most recently from 01e7f26 to 16bedb5 Compare July 25, 2023 18:45
@triallax triallax marked this pull request as ready for review July 25, 2023 18:46
@triallax triallax marked this pull request as draft July 25, 2023 19:05
@triallax triallax marked this pull request as ready for review July 25, 2023 19:22
srcpkgs/cjs/template Outdated Show resolved Hide resolved
@triallax triallax changed the title Update Cinnamon packages Cinnamon 5.8.x Jul 26, 2023
@classabbyamp classabbyamp merged commit 82a1781 into void-linux:master Jul 31, 2023
8 checks passed
@triallax triallax deleted the cinnamon-5.8.1 branch July 31, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants