Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: sq-0.42.0 #45023

Merged
merged 1 commit into from
Sep 9, 2023
Merged

New package: sq-0.42.0 #45023

merged 1 commit into from
Sep 9, 2023

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Jul 13, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture: x86_64

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 14, 2023
pkgname=sq
version=0.40.0
revision=1
archs="x86_64* aarch64*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reasoning to limit archs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't build in 32-bit systems, at least in CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why preclude ppc64 and riscv64 then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Void doesn't officially support ppc anymore, does it? And I have no way to verify if it actually builds for riscv so I didn't include it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet there's no reason to spoil the fun for those who build on their own.

@icp1994 icp1994 changed the title New package: sq-0.40.0 New package: sq-0.42.0 Sep 2, 2023
@leahneukirchen
Copy link
Member

This fixes compilation on 32-bit, feel free to upstream:

--- sq-0.42.0/libsq/ast/render/range.go.orig
+++ sq-0.42.0/libsq/ast/render/range.go
@@ -27,7 +27,7 @@
                if rr.Limit == -1 {
                        // MySQL requires a LIMIT if OFFSET is used. Therefore
                        // we make the LIMIT a very large number
-                       limit = fmt.Sprintf("LIMIT %d", math.MaxInt64)
+                       limit = fmt.Sprintf("LIMIT %d", uint64(math.MaxInt64))
                }
        }

@icp1994
Copy link
Contributor Author

icp1994 commented Sep 9, 2023

Thank you!

@Piraty Piraty merged commit 4e57114 into void-linux:master Sep 9, 2023
8 checks passed
@neilotoole
Copy link

Hi, I'm the sq author. @icp1994's PR has been merged, and released as sq v0.42.1. Let me know if there's anything else I can do to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants