Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix for 32-bit systems #308

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Sep 9, 2023

See some relevant discussions in void-linux/void-packages#45023.

@neilotoole neilotoole merged commit 82491db into neilotoole:master Sep 10, 2023
1 check passed
@neilotoole
Copy link
Owner

@icp1994 I've merged this change, and released it in v0.42.1. Let me know if it resolves the issue completely. Many thanks.

@icp1994 icp1994 deleted the patch-1 branch September 11, 2023 16:01
@icp1994
Copy link
Contributor Author

icp1994 commented Sep 11, 2023

Yes, it's no longer required to patch manually downstream 🎉

I'm curious about how you run the tests for the project. I tried to run go test ./... from the project root but it would take ages so I had to manually terminate. But I see in your CI it only takes a couple of minutes to run tests. So should I rather go test .cli/... instead?

@neilotoole
Copy link
Owner

@icp1994 So, it's a bit of a challenge. There's a doc on the sq.io site, which is a bit out of date. I should probably refactor that, or even move it into the README.

TLDR: many of the tests depend on having a database available (MySQL, Postgres, etc), BUT... if those databases aren't available, those tests should be automatically skipped.

That is to say, you should be able to execute go test ./... and it should work.

What happens if you run the tests with -v?

# From sq project root
$ go test -v ./...

Note that there are a lot of tests, so it won't be a fast process.

@icp1994
Copy link
Contributor Author

icp1994 commented Sep 11, 2023

Yes, as I said it's not failing but was taking a long time. But I saw in CI here the Run tests phase took ~3 mins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants