Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: hctl-0.2.6 #45905

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

michalszmidt
Copy link

@michalszmidt michalszmidt commented Sep 4, 2023

Testing the changes

  • I tested the changes in this PR: YES

note:

  • xlint reports no problems
  • tested with XBPS_CHECK_PKGS=yes and -Q

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-glibc
    • armv7l-glibc
    • armv6l-glibc
    • i686-glibc

note:

  • not tested on void *-musl but, on alpine succeeds with all arches including riscv64

About:
This tool allows to manage host domain blocking (hostlist generation from multiple sources, record de-duplication). It operates in parallel. Also it's optimized for memory. It's cool comparing to some nasty scripts or sed especially when you count records in millions.

Info:

Packaging status

Alpine Linux Package request - uses musl, may be helpful for bug tracing, accepted to testing

Disclaimer:
I'm a hctl author.

Have a nice day!

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 5, 2023
@classabbyamp
Copy link
Member

Do you need Cargo.lock, or this approach is acceptable?

it is recommended rust crate practice to track cargo.lock in git for applications.

Also, we prefer that package template maintainers are not the upstream maintainers unless they use Void.

@michalszmidt
Copy link
Author

Ok, so required changes are:

  • add Cargo.toml now as a separate file. (With next stable release I'll include it upstream)
  • last line of template should not be empty (my nasty editor had to add it on save)

I'll amend and fore push

Questions:

  • Do you wish to change commit message to some specific?
  • Alpine uses cargo-auditable, should it be used here?

Void glibc is my default desktop OS, but you decide.

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wish to change commit message to some specific?

see CONTRIBUTING.md

Alpine uses cargo-auditable, should it be used here?

it's already being used

Void glibc is my default desktop OS, but you decide.

ok that's fine, just checking. we just want to ensure that the template maintainer actually tests the software on void.

srcpkgs/hctl/template Outdated Show resolved Hide resolved
srcpkgs/hctl/template Outdated Show resolved Hide resolved
srcpkgs/hctl/template Outdated Show resolved Hide resolved
@michalszmidt
Copy link
Author

michalszmidt commented Sep 5, 2023

Done:

  • see CONTRIBUTING.md
  • no archs= is equivalent with "all archs"
  • hostmakedepends="pkg-config"
  • for now, it's better to just use cargo generate-lockfile for this

srcpkgs/hctl/template Outdated Show resolved Hide resolved
@michalszmidt michalszmidt changed the title New package: hctl-0.2.2 New package: hctl-0.2.2.1 Sep 5, 2023
@michalszmidt
Copy link
Author

@classabbyamp
Is there anything else I need to do?

@michalszmidt michalszmidt changed the title New package: hctl-0.2.2.1 New package: hctl-0.2.4 Oct 14, 2023
@michalszmidt
Copy link
Author

Updated to 0.2.4, as promised now Cargo.lock is upstream

@michalszmidt
Copy link
Author

@classabbyamp
Updated to 0.2.5 and rebased, is there anything else I can do?

@michalszmidt michalszmidt changed the title New package: hctl-0.2.4 New package: hctl-0.2.5 Dec 6, 2023
@melroy89
Copy link
Contributor

LGTM now..?

@michalszmidt michalszmidt changed the title New package: hctl-0.2.5 New package: hctl-0.2.6 Mar 4, 2024
@michalszmidt
Copy link
Author

LGTM now..?

Update to 0.2.6

  • Semi-important dependencies update
  • New features
  • Requires rust 1.74+

Also, all desired features are highlighted, published a roadmap to 1.0.0

Copy link

github-actions bot commented Jun 3, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 3, 2024
@melroy89
Copy link
Contributor

melroy89 commented Jun 3, 2024

BUMP! And merge plz

@github-actions github-actions bot removed the Stale label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants