Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrusaSlicer: update to 2.6.1. #46799

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vaelatern
Copy link
Member

draft, for CI

@Vaelatern
Copy link
Member Author

Well. Needs nanosvg...

#/|/ Copyright (c) Prusa Research 2022 - 2023 Enrico Turri @enricoturri1966, Tomáš Mészáros @tamasmeszaros
#/|/
#/|/ PrusaSlicer is released under the terms of the AGPLv3 or higher
#/|/
# In PrusaSlicer 2.6.0 we switched from https://github.com/memononen/nanosvg to its fork https://github.com/fltk/nanosvg
# because this last implements the new function nsvgRasterizeXY() which we now use in GLTexture::load_from_svg()
# for rasterizing svg files from their original size to a squared power of two texture on Windows systems using
# AMD Radeon graphics cards

prusaslicer_add_cmake_project(NanoSVG
    URL https://github.com/fltk/nanosvg/archive/abcd277ea45e9098bed752cf9c6875b533c0892f.zip
    URL_HASH SHA256=e859938fbaee4b351bd8a8b3d3c7a75b40c36885ce00b73faa1ce0b98aa0ad34
)

It seems like a poor candidate for packaging. Not sure what to do with that.

@Vaelatern
Copy link
Member Author

It may be best to use nanosvg as a distfile.

@agausmann
Copy link
Contributor

Yeah, I think that's reasonable, it's just a header-only library

@Vaelatern
Copy link
Member Author

Progress, do need to convince cmake to be happy with what it has.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Feb 16, 2024
@Vaelatern Vaelatern marked this pull request as draft February 16, 2024 18:19
@Vaelatern Vaelatern self-assigned this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants