[rfc] build-style: go: set buildmode=pie globally

[dkwo]

I rebuilt all packages natively on x86_64-glibc.
Packages that failed to build with pie have nopie set.

Pending:

• sbctl sbctl: update #46165

Building with pie may interfere with static binaries (e.g. if set CGO_ENABLED=0) and cross-compiling.
Up to now I disabled it for

• go-bindata
• go-md2man
• grafana

but further investigation/tests are needed. See also https://go-review.googlesource.com/c/go/+/248199

[ci skip]

[leahneukirchen]

So, which packages do you expect to fail and why?

I'd also recommend do apply this together with a Go release bump.

[CameronNemo]

Regarding LXD / Incus... I do want to migrate to Incus and completely remove LXD down the line. Don't really have time for that right now though :/

[benalb]

about bombadillo, I tried to rise an issue upstream, but they do not allow rising issues without a tilde account, that I do not have. Right now I am in the #helpedesk channel in tilde irc, waiting to someone to reply to me.

Update, very nicely, they created an tilde account for me, I could rise an issue about the timeout error, and also they pointed me to go-gitea/gitea#27945

It seems the bug issue has been resolved, I can donwload the tar.gz again.

[dkwo]

Second rebuild completed, nothing new to report.

[dkwo]

@leahneukirchen Can you take a look?
In summary, sbctl is fixed in linked pr; lxd is broken since go 1.21 (unnoticed b/c they moved distfiles) and should be replaced with incus anyway; clipman has no distfiles, but builds fine with pie if using alternative ones, so not an issue here.

[leahneukirchen]

sgtm!

[classabbyamp]

why does nopie need nostrip set? go packages have been stripped for a while now

[dkwo]

Indeed, nostrip is not necessary anymore, I removed it.

[dkwo]

there are some issues with go-bindata, and possibly with go-md2man, as well as git grep CGO_ENABLED=0.
need to look closer.

for example, crosscompiling go-bindata for aarch64-musl, adding

post_install() {
        file $DESTDIR/usr/bin/go-bindata
}

on master gives /destdir/aarch64-linux-musl/go-bindata-3.0.7.20151023/usr/bin/go-bindata: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=049Th31uwiIuGRUL3pij/OnBl5ikERfjKZV3TIvKW/hNR_lVksP6VDJDygk29J/d7c2_zRYyzhoaXpqlU1c, with debug_info, not stripped while on this branch gives
/destdir/aarch64-linux-musl/go-bindata-3.0.7.20151023/usr/bin/go-bindata: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, Go BuildID=2VcK8rq3V28QzwdA132q/aOXGyFpFnGRjrhFln2o8/QIb7J48ItHPlMUWCBeq-/j_Cj8T_yxdd9IaS_3uto, with debug_info, not stripped.