-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfc] build-style: go: set buildmode=pie globally #46958
base: master
Are you sure you want to change the base?
Conversation
d8efa4d
to
5c4755e
Compare
So, which packages do you expect to fail and why? I'd also recommend do apply this together with a Go release bump. |
Regarding LXD / Incus... I do want to migrate to Incus and completely remove LXD down the line. Don't really have time for that right now though :/ |
about bombadillo, I tried to rise an issue upstream, but they do not allow rising issues without a tilde account, that I do not have. Right now I am in the #helpedesk channel in tilde irc, waiting to someone to reply to me. Update, very nicely, they created an tilde account for me, I could rise an issue about the timeout error, and also they pointed me to go-gitea/gitea#27945 It seems the bug issue has been resolved, I can donwload the tar.gz again. |
Second rebuild completed, nothing new to report. |
9158dc9
to
d4d35f7
Compare
@leahneukirchen Can you take a look? |
sgtm! |
why does |
Indeed, |
3da9687
to
e38db7b
Compare
c144f20
to
24670ec
Compare
there are some issues with go-bindata, and possibly with go-md2man, as well as for example, crosscompiling go-bindata for aarch64-musl, adding
on master gives |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
I rebuilt all packages natively on x86_64-glibc.
Packages that failed to build with
pie
havenopie
set.Building with pie may interfere with static binaries (e.g. if set
CGO_ENABLED=0
).Up to now I disabled it for
but further investigation/tests are needed.
See also https://go-review.googlesource.com/c/go/+/248199
golang/go#41944
Todo: clean up
git grep buildmode=pie
[ci skip]