Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: update to 0.13.1 #47973

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Daxot
Copy link
Contributor

@Daxot Daxot commented Dec 29, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@Daxot Daxot force-pushed the alacritty-update branch 2 times, most recently from e73aa9b to e68c9c0 Compare December 29, 2023 14:06
@tjkirch
Copy link
Contributor

tjkirch commented Dec 30, 2023

@Daxot @heindsight Was this intended to update Chrome too? I was going to give it a test, but I don't use Chrome, and updating it here seemed odd.

@Daxot
Copy link
Contributor Author

Daxot commented Dec 30, 2023

@Daxot @heindsight Was this intended to update Chrome too? I was going to give it a test, but I don't use Chrome, and updating it here seemed odd.

Oh, my fault. Resolved!

@tjkirch
Copy link
Contributor

tjkirch commented Dec 31, 2023

Thanks! I can confirm that this update works for me.

However, I quickly ran into alacritty/alacritty#7472 (a startup performance problem) so I downgraded back to 0.12.3. It may be worth waiting for 0.13.1? A number of people with different setups reported the same problem in that issue.

@tjkirch
Copy link
Contributor

tjkirch commented Jan 8, 2024

Alacritty 0.13.1 is out now, which supposedly fixes that startup issue: https://github.com/alacritty/alacritty/releases/tag/v0.13.1

@dataCobra
Copy link
Contributor

@tjkirch did you had the time to check if 0.13.1 fixed your startup issue?

@tjkirch
Copy link
Contributor

tjkirch commented Jan 9, 2024

@tjkirch did you had the time to check if 0.13.1 fixed your startup issue?

Yes, 0.13.1 works fine for me, and it no longer has the startup delay. I'll make a suggestion to the PR.

(Tangent: I had to update .xbps-checkvers-0.58.plist to reference cargo 1.75 instead of 1.74, otherwise it was going to rebuild all of rust, llvm, etc., which my machine can't handle. I'm not an expert with xbps-based builds, so I don't know if that would affect anything with this package; I'm guessing it's just a timing issue in the repos...)

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested 0.13.1 using these changes, and it worked fine and no longer had the startup delay from 0.13.0.

srcpkgs/alacritty/template Outdated Show resolved Hide resolved
srcpkgs/alacritty/template Outdated Show resolved Hide resolved
@Daxot Daxot changed the title alacritty: update to 0.13.0 alacritty: update to 0.13.1 Jan 9, 2024
@Daxot
Copy link
Contributor Author

Daxot commented Jan 9, 2024

Updated PR to 0.13.1 version

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leahneukirchen leahneukirchen merged commit 6fd86d1 into void-linux:master Jan 12, 2024
8 checks passed
@0323pin
Copy link

0323pin commented Jan 13, 2024

alacritty is broken and I can not launch a terminal from my user session. I've installed xterm to get the reason, it reads:

thread 'main' panicked at /host/cargo/registry/src/index.crates.io-6f17d22bba15001f/xkbcommon-dl-0.4.1/src/x11.rs:59:28:
Library libxkbcommon-x11.so could not be loaded.

I run alacritty-dev-0.14.0 on NetBSD and suspect there as a dependency or, linking missing in the updated Void package.
Can someone have a look?
Thanks!

@dataCobra
Copy link
Contributor

Hmm, for me it works flawless.

@0323pin could you please create an issue with all the relevant information?
I think that is better suited in the case then using the merged PR.

@0323pin
Copy link

0323pin commented Jan 13, 2024

Sure, I'll create an issue.

@dataCobra
Copy link
Contributor

Thanks but I can tell you I've already found the issue.

alacritty has a dependency with libxkbcommon-x11.

I'll create a PR asap to get that fixed.

@0323pin
Copy link

0323pin commented Jan 13, 2024

Thanks!

Yes, I know about the dependency. I maintain the package for NetBSD and as said run the dev version also.

@0323pin
Copy link

0323pin commented Jan 13, 2024

Manually installing the dependency fixes it.

@dataCobra
Copy link
Contributor

@0323pin I created a new PR #48197 for the fix and will contact the Void devs for a quick merge.

@0323pin
Copy link

0323pin commented Jan 13, 2024

Thank you.

@Daxot Daxot deleted the alacritty-update branch January 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants