Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: gamescope-3.14.1 #48354

Merged
merged 2 commits into from Feb 16, 2024
Merged

New package: gamescope-3.14.1 #48354

merged 2 commits into from Feb 16, 2024

Conversation

dexgs
Copy link
Contributor

@dexgs dexgs commented Jan 24, 2024

Add Valve's Gamescope as requested in #36869. If this is merged, steamos-compositor should probably be removed from the repository at some point.

This PR also adds libliftoff as a dependency. Gamescope also vendors some dependencies, but I believe I've handled this correctly.

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

srcpkgs/gamescope/template Outdated Show resolved Hide resolved
srcpkgs/gamescope/template Show resolved Hide resolved
srcpkgs/libliftoff/template Outdated Show resolved Hide resolved
srcpkgs/gamescope/template Outdated Show resolved Hide resolved
srcpkgs/libliftoff/template Outdated Show resolved Hide resolved
@dexgs dexgs force-pushed the gamescope branch 2 times, most recently from 9a2353d to 98343a6 Compare January 31, 2024 14:36
@dexgs
Copy link
Contributor Author

dexgs commented Jan 31, 2024

@classabbyamp I've pushed changes with your corrections

srcpkgs/gamescope/template Outdated Show resolved Hide resolved
# provide a simple way to exclude single tests, so this is required.
do_check() {
test_list=$(meson test -C build --list)
meson test -C build ${test_list//check_ndebug}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just rm the files for this check in pre_check()?

srcpkgs/gamescope/template Show resolved Hide resolved
srcpkgs/gamescope/template Outdated Show resolved Hide resolved
@dexgs
Copy link
Contributor Author

dexgs commented Jan 31, 2024

@classabbyamp Done. I think deleting the check_ndebug files in libliftoff would break the build, so I removed the test by deleting a line from the meson.build in post_extract().

@classabbyamp
Copy link
Member

post_patch would be a better place but the solution is fine by me

@dexgs
Copy link
Contributor Author

dexgs commented Feb 1, 2024

Done

@classabbyamp
Copy link
Member

 /usr/bin/gamescope
-/usr/include/vkroots.h
 /usr/lib/libVkLayer_FROG_gamescope_wsi_x86_64.so
-/usr/lib/pkgconfig/vkroots.pc
 /usr/share/licenses/gamescope/LICENSE
-/usr/share/licenses/gamescope/LICENSE.reshade
-/usr/share/licenses/gamescope/LICENSE.vkroots
 /usr/share/vulkan/implicit_layer.d/VkLayer_FROG_gamescope_wsi.x86_64.json

based on what other distros are doing, I don't think those files are necessary in the package

@dexgs
Copy link
Contributor Author

dexgs commented Feb 1, 2024

based on what other distros are doing, I don't think those files are necessary in the package

I understand why not to include the pkgconfig/header files for the vendored vkroots, but why not include the licenses of the vendored dependencies?

@dexgs
Copy link
Contributor Author

dexgs commented Feb 2, 2024

@classabbyamp done. Not sure if i removed the header/pkgconfig files correctly, i just used rm in post_install()

@@ -0,0 +1,50 @@
# Template file for 'gamescope'
pkgname=gamescope
version=3.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 4.4.2 is available

@dexgs
Copy link
Contributor Author

dexgs commented Feb 16, 2024

@classabbyamp I applied the change to libliftoff. I don't see a version 4.4.2 for gamescope, only 3.14.1 which was released yesterday. I'm assuming that's what you meant.

@dexgs dexgs changed the title New package: gamescope-3.14.0 New package: gamescope-3.14.1 Feb 16, 2024
@classabbyamp
Copy link
Member

classabbyamp commented Feb 16, 2024

@classabbyamp
Copy link
Member

ok it's picking up tags from https://github.com/Joshua-Ashton/reshade, an update file containing site=https://github.com/ValveSoftware/gamescope/tags should be enough

@dexgs
Copy link
Contributor Author

dexgs commented Feb 16, 2024

then it probably needs an update file

done

@classabbyamp classabbyamp merged commit 1017a0c into void-linux:master Feb 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants