Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incus: update to 6.2 #50251

Merged
merged 2 commits into from
Jun 6, 2024
Merged

incus: update to 6.2 #50251

merged 2 commits into from
Jun 6, 2024

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented May 8, 2024 •
edited

Tested.

@dkwo dkwo marked this pull request as draft May 8, 2024 23:22
@dkwo dkwo mentioned this pull request May 9, 2024
Closed
@dkwo dkwo marked this pull request as ready for review May 11, 2024 21:53
@dkwo
Copy link
Contributor Author

dkwo commented May 23, 2024

@ahesford can you take a look at this one as well?

@sbromberger
Copy link
Contributor

Hi all,

6.2 was just released - any way we might just bump the version here?

ahesford
ahesford requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any experience with incus, but I've made a few suggestions to improve the readme and variable handling in the template.

srcpkgs/incus/template Outdated Show resolved Hide resolved
srcpkgs/incus/files/README.voidlinux Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Jun 5, 2024 via email

@dkwo
Copy link
Contributor Author

dkwo commented Jun 5, 2024

Still failing on 32 bit. I thought that patch had been merged in v6.2
is anyone actually using incus on those archs? I wonder if it's worth it supporting them..

@dkwo dkwo mentioned this pull request Jun 5, 2024
Closed
@dkwo dkwo changed the title incus: update to 6.1 incus: update to 6.2 Jun 5, 2024
@dkwo dkwo marked this pull request as draft June 5, 2024 12:49
@dkwo
Copy link
Contributor Author

dkwo commented Jun 5, 2024

the patch fixes 32 bit. i'll leave this as draft until it is merged upstream.

@dkwo dkwo marked this pull request as ready for review June 6, 2024 20:27
@dkwo
Copy link
Contributor Author

dkwo commented Jun 6, 2024

patch now merged upstream.

@dkwo dkwo requested a review from ahesford June 6, 2024 20:27
@ahesford ahesford merged commit 5611ff8 into void-linux:master Jun 6, 2024
8 checks passed
@sbromberger
Copy link
Contributor

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahesford ahesford Awaiting requested review from ahesford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkwo @sbromberger @ahesford