Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: update to 20.13.1 #50485

Closed
wants to merge 8 commits into from
Closed

Conversation

MIvanchev
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: NO

@leahneukirchen
Copy link
Member

Please take a look at https://github.com/void-linux/void-packages/pull/47249/files to see what other changes may be needed.

@MIvanchev
Copy link
Contributor Author

@leahneukirchen It appears electron no longer builds but I thing for an unrelated reason, i.e.

In file included from ../../third_party/abseil-cpp/absl/strings/internal/str_format/extension.cc:16:
../../third_party/abseil-cpp/absl/strings/internal/str_format/extension.h:34:35: error: unknown type name 'uint8_t'

Do you have an clue to this?

@leahneukirchen
Copy link
Member

leahneukirchen commented May 25, 2024

That needs a #include <cstdint> somewhere.

@MIvanchev MIvanchev changed the title [WIP] nodejs: update to 20.13.1 nodejs: update to 20.13.1 May 30, 2024
@MIvanchev
Copy link
Contributor Author

I'm removing the WIP status here and arguing that a significant number of projects continue to build successfully with the updated nodejs.

@brian6932
Copy link

brian6932 commented Jul 1, 2024

Any chance of this getting merged/anything holding this back from being merged? Just testing? The current package's extremely out of date :P

@dkwo
Copy link
Contributor

dkwo commented Jul 29, 2024

Shouldn't the FIXME line in Signal be dropped?

@MIvanchev
Copy link
Contributor Author

@dkwo Indeed it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants