[WIP] build-style/meson: fix building rust apps #7341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will test gnome-podcasts tomorrow. |
jnbr
reviewed
Jan 18, 2019
common/build-style/meson.sh
Outdated
| @@ -64,6 +65,17 @@ endian = '${_MESON_TARGET_ENDIAN}' | |||
| EOF | |||
| configure_args+=" --cross-file=${meson_crossfile}" | |||
|
|
|||
| # Fix building Rust apps | |||
| mkdir .cargo | |||
There was a problem hiding this comment.
better use mkdir -p .cargo here
There was a problem hiding this comment.
How could ${wrksrc} not exist here?
There was a problem hiding this comment.
Oh, right, -p also deals with that
maxice8
reviewed
Jan 18, 2019
| export GETTEXT_BIN_DIR=/usr/bin | ||
| export GETTEXT_LIB_DIR="${XBPS_CROSS_BASE}/usr/lib/gettext" | ||
| export GETTEXT_INCLUDE_DIR="${XBPS_CROSS_BASE}/usr/include" | ||
| export LIBSSH2_SYS_USE_PKG_CONFIG=1 |
There was a problem hiding this comment.
I would prefer a solution which doesn't involve maintaining two copies of this list
There was a problem hiding this comment.
Hm, can we share envs between build styles? Adding it to the global env seems meh to me
|
On Thu, Jan 17, 2019 at 04:44:37PM -0800, Rasmus Thomsen wrote:
Cogitri commented on this pull request.
> @@ -1 +1,9 @@
hostmakedepends+=" meson"
+
+export PKG_CONFIG_ALLOW_CROSS=1
+
+export LIBGIT2_SYS_USE_PKG_CONFIG=1
+export GETTEXT_BIN_DIR=/usr/bin
+export GETTEXT_LIB_DIR="${XBPS_CROSS_BASE}/usr/lib/gettext"
+export GETTEXT_INCLUDE_DIR="${XBPS_CROSS_BASE}/usr/include"
+export LIBSSH2_SYS_USE_PKG_CONFIG=1
Hm, can we share envs between build styles? Adding it to the global env seems meh to me
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#7341 (comment)
NOt between build_styles, maybe we can change that.
|
|
This will be fixed by build_helper #7505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.