New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common/xbps-src: source all files under a directory named after the build-style. #7372
Conversation
Interesting idea, I wonder if all possible entry points were covered, I'll grep for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting proposal, one that I'm not sure I fully understand the value. Please rebase to pick up the most recent fixes to the go style and then expound some upon the benefits of this strategy.
As explained before it's handy for stuff like #7322 where meson-rust needs the same env as cargo |
build-style. This allows a build-style to have various .sh under it, one important use-case is sharing environment variables that can be set under multiple build-styles. As an example both cargo and meson build-style need to set various rust flags, see #7322.
between build-styles.
Nice idea! I think this could be useful. We should introduce a build-style environment variable that points to |
I don't think build styles need to be more complex. The cargo configuration shouldn't depend on the |
superseeded by build_helper |
This allows a build-style to have various .sh under it, one important
use-case is sharing environment variables that can be set under multiple
build-styles.
As an example both cargo and meson build-style need to set various rust
flags, see #7322.
@Cogitri