Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/xbps-src: source all files under a directory named after the build-style. #7372

Closed
wants to merge 4 commits into from

Conversation

maxice8
Copy link
Contributor

@maxice8 maxice8 commented Jan 18, 2019

This allows a build-style to have various .sh under it, one important
use-case is sharing environment variables that can be set under multiple
build-styles.

As an example both cargo and meson build-style need to set various rust
flags, see #7322.

@Cogitri

@Vaelatern
Copy link
Member

Interesting idea, I wonder if all possible entry points were covered, I'll grep for that.

Copy link
Member

@the-maldridge the-maldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An interesting proposal, one that I'm not sure I fully understand the value. Please rebase to pick up the most recent fixes to the go style and then expound some upon the benefits of this strategy.

@Cogitri
Copy link
Contributor

Cogitri commented Jan 19, 2019

As explained before it's handy for stuff like #7322 where meson-rust needs the same env as cargo

build-style.

This allows a build-style to have various .sh under it, one important
use-case is sharing environment variables that can be set under multiple
build-styles.

As an example both cargo and meson build-style need to set various rust
flags, see #7322.
@Gottox
Copy link
Member

Gottox commented Jan 19, 2019

Nice idea!

I think this could be useful. We should introduce a build-style environment variable that points to $XBPS_COMMONDIR/build-style to ease linking and including other files. What do you think?

@Duncaen
Copy link
Member

Duncaen commented Jan 19, 2019

I don't think build styles need to be more complex.

The cargo configuration shouldn't depend on the build_style because at the end any buildstyle could need it, librsvg and firefox are examples that use no build_style and gnu-configure.

@maxice8
Copy link
Contributor Author

maxice8 commented Jan 22, 2019

superseeded by build_helper

@maxice8 maxice8 closed this Jan 22, 2019
@maxice8 maxice8 deleted the cogitri branch January 22, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants