Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an options.verboseLogging option to enable/disable logging #1

Merged
merged 6 commits into from
Jul 17, 2018

Conversation

batmat
Copy link
Contributor

@batmat batmat commented Jul 17, 2018

hello @void666, what do you think about this? I am already wrapping the download part of our code with logging, so I'd like to disable the one coming from your library.

I'm still leaving the error-related ones on purpose. I'm just trying to remove the logs for the nominal case.

Thanks 馃樃 !

@coveralls
Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 19

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 98.361%

Totals Coverage Status
Change from base Build 13: 0.4%
Covered Lines: 41
Relevant Lines: 41

馃挍 - Coveralls

@void666
Copy link
Owner

void666 commented Jul 17, 2018

@batmat, looks good! However was deliberating whether to use the logger's default logging level instead of adding additional one.

@batmat
Copy link
Contributor Author

batmat commented Jul 17, 2018

@void666 yeah, I guess indeed if you consider that code a library, this shouldn't try and define/use a fancy logging style/formatting, but leave that to the calling system/global config. But I'm still a Node newbie, so, well :).

- changing to snake_case verbose_logging. Maintain format for global options.
- changing to snake_case
- changing to snake_case
- updated `verbose_logging` instead of `verboseLogging`
@void666 void666 merged commit 95169f9 into void666:master Jul 17, 2018
@batmat batmat deleted the option-to-disable-logging branch July 17, 2018 12:46
@batmat
Copy link
Contributor Author

batmat commented Jul 17, 2018

\o/ thanks a bunch @void666. Any possibility of a 1.0.1 release or something with this?

Thanks again!

@void666
Copy link
Owner

void666 commented Jul 17, 2018

Done already @batmat . Thanks for the contribution.

@batmat batmat mentioned this pull request Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants